Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the notation in xSM to match section 6.1 and manySinglets.py #346

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Changed the notation in xSM to match section 6.1 and manySinglets.py #346

merged 2 commits into from
Nov 6, 2024

Conversation

benoitlaurent96
Copy link
Collaborator

No description provided.

@benoitlaurent96 benoitlaurent96 requested a review from og113 November 5, 2024 19:02
og113
og113 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@og113 og113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Models work locally. grep says the only remaining examples of a2 and b4 are in the manySinglets.py model, which I think is fine.

@og113
Copy link
Collaborator

og113 commented Nov 6, 2024

I'm gonna merge this, so we can get on with the release.

@og113 og113 merged commit 7271d87 into main Nov 6, 2024
6 checks passed
@og113 og113 deleted the xSMNotation branch November 6, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@og113 og113 og113 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoitlaurent96 @og113