Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: Make the min_nodes_to_process network specific #173

Merged
merged 1 commit into from
Nov 2, 2023
Merged

network: Make the min_nodes_to_process network specific #173

merged 1 commit into from
Nov 2, 2023

Conversation

ksedgwic
Copy link
Collaborator

@ksedgwic ksedgwic commented Aug 21, 2023 •
edited
Loading

TODO:

  • Validate network specific behavior
  • Address signet if the default of 10 is not appropriate

@ksedgwic ksedgwic mentioned this pull request Aug 21, 2023
Merged
@ksedgwic ksedgwic force-pushed the network-min-nodes-to-process branch from 52758c5 to 40d71bc Compare September 6, 2023 17:52
@ksedgwic ksedgwic mentioned this pull request Sep 11, 2023
Closed
1 task
@ksedgwic
network: Make the min_nodes_to_process network specific
c1bb9c6 
Changelog-Changed: Made the min_nodes_to_process network specific.
@ksedgwic ksedgwic force-pushed the network-min-nodes-to-process branch from 40d71bc to c1bb9c6 Compare October 31, 2023 21:36
@ksedgwic
Copy link
Collaborator Author

ksedgwic commented Nov 1, 2023

@vincenzopalazzo Does this PR look ok to you? This allows CLBOSS to "engage" on testnet. I'm not exactly sure how many nodes to expect when folks run in regtest or signet but lowering the threshold to 10 seems likely to be better than the current mainnet setting of 800 ...

vincenzopalazzo
vincenzopalazzo approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c1bb9c6

Make sense to me.

Sorry I miss the notification of this PR

@ksedgwic ksedgwic merged commit 9c050d6 into ZmnSCPxj:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksedgwic @vincenzopalazzo