Use the rightmost IP from Forwarded header and add $trustedProxiesCount parameter #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trusted proxies count parameter is used to ignore a specific number of IPs on the Forwarded header list, as they're considered trusted or known. This commit also: - adds types to some constructor parameters - updates comments on parameters
As the leftmost IPs on the Forwarded header list can be spoofed, we are now taking the rightmost IPs from the list. The library now includes a fifth parameter called $trustedProxiesCount, which is used to ignore a certain number of IPs from the Forwarded header list, so trusted or known IPs can be ignored.
Test now take into account to use the rightmost IP from the Forwarded header list and to be able to ignore a number of IPs with the $trustedProxiesCount parameter
- Add information of the $trustedProxiesCount parameter - Inform that the library now uses the rightmost IP of the Forwarded header list
|
Superseded by #51, though this doesn't cover counting the trusted proxies as that was less pressing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Rob,
This PR adds some changes to the library:
Let me know what you think and if any improvements can be made.
Thanks!