Trust the first non-trusted-proxy IP address from the right #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easier to type `composer check` to ensure that the changes will pass CI.
We want the IP address that is immediately next after the known proxies.
Any IP addresses to the left after the known proxies are irrelevant and could have been spoofed. Therefore we need to select the first IP address from the right that is not a trusted proxy.
akrabat
force-pushed
the
45-trust-from-the-right
branch
from
f88ca0f to
3595b64
Compare
|
@aiglesiasn, @cxlblm: I would appreciate a look-over of this proposed solution. |
aiglesiasn
approved these changes
Dec 18, 2024
This is not supported on PHP 7.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining the client's IP address from a forwarded header, we need to take the rightmost IP address that is not a trusted proxy as this IP address is the added by the trusted proxy. Any other IP addresses to the left of that one could have been spoofed and so are untrustworthy.
Supersedes #50.
Closes #45