Support PostgreSQL connection with SSL #1243

[unical1988]

I added tsx and go codes for backend and frontend to support SSL for PostgreSQL.

[unical1988]

I now made the select and checkbox two seperated form groups and remove handleChange()

[unical1988]

Your comments suggest fixing the frontend part of the new feature, are there problems with the backend commited code?

[unical1988]

Is the connection string building for the DB correct (in internal/install/install_req.go)?. I assume the pem and crt files should be found in the folder data/cache/certs/

[shuashuai]

I now made the select and checkbox two seperated form groups and remove handleChange()

An important point is that you have locally verified the code you submitted now? Can the front-end project run correctly?
If you haven't read the development guide, please go to the official website to read the development guide first.

I checked it and it still didn't handle the translation completely. In addition, if your editor uses vscode, it is recommended to install the eslint plugin.

SSL Mode On element, why not apply to react-bootstrap components? And why doesn't the checkbox value apply to the value you passed in, but continue to use the value on the current page?

I'm not sure if you end up submitting and saving the value of SSL Mode checkbox to the database. If it's just a logic of whether select is displayed, then it doesn't need to be saved in formData, it just needs to be processed within the current component.

The following is content without translation

[shuashuai]

Your comments suggest fixing the frontend part of the new feature, are there problems with the backend commited code?

I currently only review the front-end code, and the back-end code needs to wait for @LinkinStars to review it.

[unical1988]

I am in the process of testing right now, I will check your comments and make the changes in the next commits

[unical1988]

I made few other frontend fixes (except relating to handle the translations)

[shuashuai]

I made few other frontend fixes (except relating to handle the translations)

1. there are still ts errors reported in development mode

2. the translation file should be in the i18n directory. What do you ask about creating and submitting the language file in the cmd directory

There are some tutorials on Answer development on the official blog that may be helpful for you to be familiar with projects and development. You can read it.

[LinkinStars]

Is the connection string building for the DB correct (in internal/install/install_req.go)?. I assume the pem and crt files should be found in the folder data/cache/certs/

@unical1988 All the files required for SSL, such as .pem and .crt, have an input field where users can directly enter the directory path. Users can place the files in the specified directory themselves.

[unical1988]

All the files required for SSL, such as .pem and .crt, have an input field where users can directly enter the directory path. Users can place the files in the specified directory themselves.

does it mean I have to create input text elements (3) in the UI while SSL is enabled to enable the user to specify the paths ? or is it an upload feature?

[LinkinStars]

All the files required for SSL, such as .pem and .crt, have an input field where users can directly enter the directory path. Users can place the files in the specified directory themselves.

does it mean I have to create input text elements (3) in the UI while SSL is enabled to enable the user to specify the paths ? or is it an upload feature?

@unical1988 Make it simple. Only need three input text fields.

[shuashuai]

@shuashuai how to format the front-end according to the project styling? is there a prettier command to execute to do so?

This kind of problem should be solved on its own by searching or AI.

Fix single file command npx eslint --fix [filepath]

It should also be noted that I'm not going to look at the implementation logic until it passes format checking

[sy-records]

By the way, the base branch of PR should be dev, you'll need to work out the conflicts locally.

[shuashuai]

The ssl_enabled and ssl_mode checksum is not needed and is meaningless, it's just a variable that controls the data underneath.

What needs to be checked is the value of key_file and pen_file and cert_file if ssl_enabled is true and ssl_mode is not required.

In addition, when switching ssl_anabled, please reinitialize these relevant values (ssl_mode、key_file、pen_file、cert_file)

[unical1988]

is ssl_enabled initialized somewhere? I can edit the code to account only for the values of %_file but how and where default values for ssl_mode and ssl_enabled are set? the current logic initilizes them, but you say it is not needed.

[unical1988]

I have also added the re-initialization of the relevant variables when switching ssl_enabled