Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PostgreSQL connection with SSL #1243 #1244
Support PostgreSQL connection with SSL #1243 #1244
Changes from 45 commits
bbb2e66
5886c1e
0fd7e81
17f8895
4680ad4
90af293
2a5710f
e40e299
e058e76
3948f70
aaf9bb6
8b56599
ed7b120
919c87b
98b5f80
58e6b2a
59f0496
e302026
f165177
066a0d4
86c270e
5a8118d
6ee1cdb
550d1d8
61070b1
0a2fd3e
cab4102
f12bf74
cf3f468
52b00ef
c36b80f
e67a45f
e23d10f
725c6fd
286bd4b
c17a136
b276c51
51156a8
fcb541f
ca94415
8aa2243
082a39e
5a73a91
d64d14c
fbf65dd
e5778c1
d8ba161
e419bbf
9cff793
55baf9a
a6cf7b4
f11ec86
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ssl_enabled
andssl_mode
checksum is not needed and is meaningless, it's just a variable that controls the data underneath.What needs to be checked is the value of
key_file
andpen_file
andcert_file
if ssl_enabled is true and ssl_mode is not required.In addition, when switching ssl_anabled, please reinitialize these relevant values (ssl_mode、key_file、pen_file、cert_file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
ssl_enabled
initialized somewhere? I can edit the code to account only for the values of%_file
but how and where default values forssl_mode
andssl_enabled
are set? the current logic initilizes them, but you say it is not needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also added the re-initialization of the relevant variables when switching
ssl_enabled