CAAFE: Add Bedrock Support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've merged the bedrock support PR in the fork of CAAFE (AnirudhDagar/CAAFE#1) we are using in AGA. This PR is now ready for review. |
AnirudhDagar
requested review from
boranhan,
canerturkmen and
FANGAreNotGnu
and removed request for
canerturkmen
boranhan
previously approved these changes
Nov 1, 2024
|
Do you have a run ID? |
|
I'll now initiate a run for this and share once it is done. |
|
run ID: 589 shows that bedrock does the expected job w CAAFE. |
|
what is the final result of that run? |
|
saw this results offline, LGTM |
boranhan
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Add Bedrock support to CAAFE. This PR first requires merging AnirudhDagar/CAAFE#1
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.