Skip to content

Fix Mac compatibility for Vulkan 1.3.216+ #2263

Fix Mac compatibility for Vulkan 1.3.216+

Fix Mac compatibility for Vulkan 1.3.216+ #2263

Triggered via pull request February 23, 2024 15:45
Status Failure
Total duration 1m 9s
Artifacts

ci.yml

on: pull_request
Commit message check
7s
Commit message check
Code formatting check
59s
Code formatting check
Baseline cmake check
0s
Baseline cmake check
Documentation Build
0s
Documentation Build
Android
0s
Android
Matrix: Linux
Matrix: Mac
Matrix: Windows
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 2 warnings
Code formatting check
clang-format issues were found. See CONTRIBUTING.md for more information. diff --git a/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp b/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp index 3830f94..5354e61 100644 --- a/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp +++ b/renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp @@ -411,9 +411,10 @@ RDResult WrappedVulkan::Initialise(VkInitParams &params, uint64_t sectionVersion } #ifdef RDOC_APPLE - if (supportedExtensions.find(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME) != supportedExtensions.end() && - !params.Extensions.contains(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME)) - if(!m_Replay->IsRemoteProxy()) + if(supportedExtensions.find(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME) != + supportedExtensions.end() && + !params.Extensions.contains(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME)) + if(!m_Replay->IsRemoteProxy()) RDCLOG("Enabling VK_KHR_portability_enumeration"); params.Extensions.push_back(VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME); flags |= VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR;
Code formatting check
Process completed with exit code 1.
Commit message check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Code formatting check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.