bugfix: change linker flag option for mac builds of charm4py #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericjbohm
added
MacOS
Charm4py
ritvikrao
reviewed
Mar 27, 2024
There was a problem hiding this comment.
This workaround only allows charm++ to build if I comment out a couple of lines in setup/scripts/configure.ac that blocks charm4py build. I added that commit. But even then, now I get an error when running setup.py in charm4py, saying that there's no CmiCommitId in the library file.
Traceback (most recent call last):
File "/Users/ritvik/charm4py/setup.py", line 311, in <module>
setuptools.setup(
File "/usr/local/lib/python3.11/site-packages/setuptools/__init__.py", line 107, in setup
return distutils.core.setup(**attrs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 185, in setup
return run_commands(dist)
^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
dist.run_commands()
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
self.run_command(cmd)
File "/usr/local/lib/python3.11/site-packages/setuptools/dist.py", line 1233, in run_command
super().run_command(command)
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/Users/ritvik/charm4py/setup.py", line 212, in run
install.run(self)
File "/usr/local/lib/python3.11/site-packages/setuptools/command/install.py", line 82, in run
orig.install.run(self)
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/command/install.py", line 697, in run
self.run_command('build')
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
self.distribution.run_command(command)
File "/usr/local/lib/python3.11/site-packages/setuptools/dist.py", line 1233, in run_command
super().run_command(command)
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/command/build.py", line 131, in run
self.run_command(cmd_name)
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/cmd.py", line 318, in run_command
self.distribution.run_command(command)
File "/usr/local/lib/python3.11/site-packages/setuptools/dist.py", line 1233, in run_command
super().run_command(command)
File "/usr/local/lib/python3.11/site-packages/setuptools/_distutils/dist.py", line 988, in run_command
cmd_obj.run()
File "/Users/ritvik/charm4py/setup.py", line 233, in run
build_libcharm(os.path.join(os.getcwd(), 'charm_src'), self.build_lib)
File "/Users/ritvik/charm4py/setup.py", line 175, in build_libcharm
check_libcharm_version(charm_src_dir)
File "/Users/ritvik/charm4py/setup.py", line 92, in check_libcharm_version
commit_id_str = ctypes.c_char_p.in_dll(lib, "CmiCommitID").value.decode()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: dlsym(0x7ff91e454770, CmiCommitID): symbol not found
|
On macs, the flag for linking whole archives is different than with linux, so I had to change the flag in CMakeLists. |
ritvikrao
changed the title
|
sending this message to get more eyes on it; it's a trivial flag change for darwin |
matthiasdiener
approved these changes
May 1, 2024
ZwFink
approved these changes
May 1, 2024
…_for_libcharm update workflow file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address buildold issue for libcharm as used by charm4py on Darwin