Skip to content

Commit

Permalink
Enable 2 rom tests now that functionality is implemented.
Browse files Browse the repository at this point in the history
Also ensure they pass.
  • Loading branch information
mtimkovich committed Jan 16, 2025
1 parent 12af58e commit 2a77c7c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions rom/dev/tests/rom_integration_tests/test_image_validation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2537,9 +2537,7 @@ fn test_header_verify_vendor_mldsa_pub_key_in_preamble_and_header() {
);
}

// TODO: Uncomment this test when functionality is implemented.
// #[test]
#[allow(dead_code)]
#[test]
fn test_preamble_vendor_mldsa_pubkey_out_of_bounds() {
let (mut hw, mut image_bundle) = hw_and_mldsa_image_bundle();

Expand Down
4 changes: 1 addition & 3 deletions rom/dev/tests/rom_integration_tests/test_update_reset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -508,9 +508,7 @@ fn test_fmc_is_16k() {
assert!(errs.is_empty());
}

//#[test]
// [TODO] Enable this test.
#[allow(dead_code)]
#[test]
fn test_update_reset_max_fw_image() {
let rom = caliptra_builder::build_firmware_rom(firmware::rom_from_env()).unwrap();
let image_bundle = caliptra_builder::build_and_sign_image(
Expand Down

0 comments on commit 2a77c7c

Please sign in to comment.