Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] Implement IDEVID Subject Key ID for MLDSA #1870

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

mhatrevi
Copy link
Collaborator

@mhatrevi mhatrevi commented Jan 1, 2025

This change queries the correct algorithm type for generating the IDEVID subject key id for MLDSA from the fuse_idevid_cert_attr fuse.

This change queries the correct algorithm type for generating the IDEVID subject key id for MLDSA from the fuse_idevid_cert_attr fuse.
@mhatrevi mhatrevi added the Caliptra v2.0 Items to be considered for v2.0 Release label Jan 1, 2025
swenson
swenson previously approved these changes Jan 2, 2025
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not sure how that line compiles

drivers/src/fuse_bank.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhatrevi mhatrevi enabled auto-merge (squash) January 3, 2025 19:15
@mhatrevi mhatrevi merged commit e11ed03 into main-2.x Jan 3, 2025
5 checks passed
ArthurHeymans pushed a commit that referenced this pull request Jan 13, 2025
This change queries the correct algorithm type for generating the IDEVID subject key id for MLDSA from the fuse_idevid_cert_attr fuse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants