New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify ECC and PQC digests from key descriptor #1893

Open

mtimkovich wants to merge 17 commits into main-2.x from mtimkovich/digest_descriptor

+303 −20

mtimkovich commented Jan 15, 2025

No description provided.

mtimkovich added 2 commits

January 14, 2025 14:25


          digest descriptor

af19f64


          remove temp test

d66d5eb

mtimkovich added the Caliptra v2.0 label

mtimkovich requested review from mhatrevi, ajisaxena, vsonims, korran, swenson and JohnTraverAmd as code owners

January 15, 2025 00:18

linux-foundation-easycla bot commented Jan 15, 2025 •

edited

Loading

❌ - login: @mtimkovich / name: Max Timkovich . The commit (7edcf68, 97f40ae, c0e295e, d66d5eb, 8c82da6, e2d46a4, e6ba736, c37675f, 77a80ad, b263e2d, bbe8f73, af19f64, 2b991ea, 1034fa2, 61b12dc, 6338307, 90ced2b) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

mtimkovich added 4 commits

January 14, 2025 16:28


          clippy

1034fa2


          update unit tests

c0e295e


          replace potential panic code

e2d46a4


          bump runtime size

97f40ae

mhatrevi reviewed

View reviewed changes

image/verify/src/verifier.rs Outdated Show resolved Hide resolved

mhatrevi reviewed

View reviewed changes

image/verify/src/verifier.rs Outdated Show resolved Hide resolved

mhatrevi reviewed

View reviewed changes

rom/dev/tests/rom_integration_tests/test_image_validation.rs Outdated Show resolved Hide resolved

mhatrevi reviewed

View reviewed changes

rom/dev/tests/rom_integration_tests/test_image_validation.rs Outdated Show resolved Hide resolved

mhatrevi reviewed

View reviewed changes

rom/dev/tests/rom_integration_tests/test_image_validation.rs Show resolved Hide resolved

mhatrevi requested changes

View reviewed changes

Collaborator

mhatrevi left a comment

Please see the feedback.


          rename functions

b263e2d

mhatrevi reviewed

View reviewed changes

rom/dev/tests/rom_integration_tests/test_image_validation.rs Outdated Show resolved Hide resolved

mhatrevi reviewed

View reviewed changes

rom/dev/tests/rom_integration_tests/test_image_validation.rs Outdated Show resolved Hide resolved

mtimkovich and others added 7 commits

January 17, 2025 14:44


          Enable 2 rom tests now that functionality is implemented. (#1898)

77a80ad


          digest descriptor

e6ba736


          remove temp test

7edcf68


          clippy

61b12dc


          update unit tests

90ced2b


          replace potential panic code

c37675f


          bump runtime size

bbe8f73

mtimkovich added 3 commits

January 17, 2025 15:14


          rename functions

8c82da6


          split mldsa and lms bad index. fix bug in mldsa check.

2b991ea


          Merge branch 'mtimkovich/digest_descriptor' of https://github.com/chi…

…psalliance/caliptra-sw into mtimkovich/digest_descriptor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mhatrevi mhatrevi requested changes

ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

vsonims Awaiting requested review from vsonims vsonims is a code owner

korran Awaiting requested review from korran korran is a code owner

swenson Awaiting requested review from swenson swenson is a code owner

JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

Requested changes must be addressed to merge this pull request.

Labels