This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix/double for strategy #1226
Merged
Fix/double for strategy #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iteration strategy parent
…the lower dataset reference (whitelist the dataset values)
DelaunayAlex
force-pushed
the
fix/double_for_strategy
branch
from
3b988f1 to
22a86e5
Compare
engine/src/main/java/com/chutneytesting/engine/domain/execution/engine/step/Step.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategy.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategyTest.java
Show resolved
Hide resolved
|
I have an interrogation : Do we know how the strategy behaves when the indexes are mixed up ? |
5 tasks
KarimGl
reviewed
Jan 12, 2024
engine/src/main/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategy.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/com/chutneytesting/engine/domain/execution/engine/step/StepStateTest.java
Outdated
Show resolved
Hide resolved
nbrouand
reviewed
Jan 12, 2024
engine/src/main/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategy.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategyTest.java
Show resolved
Hide resolved
In this situation the two loops will have the same index, and every will be resolved by the outer for loop because it is resolved reccursively before the inner for loops. It is on the user to explicit the index variable in the dataset. This is the same if the datasets have keys in common |
DelaunayAlex
force-pushed
the
fix/double_for_strategy
branch
from
2ae219d to
72c9826
Compare
nbrouand
suggested changes
Jan 15, 2024
engine/src/main/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategy.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/chutneytesting/engine/domain/execution/strategies/ForEachStrategy.java
Outdated
Show resolved
Hide resolved
nbrouand
approved these changes
Jan 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.