tests-scan: Add "image-download" secret #6062
Conversation
So that job containers can download private images (RHEL). This secret gets defined in cockpit-project/cockpituous#594
| @@ -282,7 +282,7 @@ def test_amqp_pr(self, mock_queue, _mock_strftime): | |||
| "slug": f"pull-{self.pull_number}-abcdef-20240102-030405-fedora-nightly", | |||
| "target": "stable-1.0", | |||
| "container": "supertasks", | |||
| "secrets": ["github-token"], | |||
| "secrets": ["github-token", "image-download"], | |||
There was a problem hiding this comment.
Is this JSON schema defined anywhere? Half of it looks like a Github event and the other part of the job looks like something Cockpit test specific?
There was a problem hiding this comment.
So the secret is image-download? I found that a bit confusing as image-download is also something I often use :) So I almost wonders if secrets was tied to an invocation.
There was a problem hiding this comment.
That secret is defined in cockpit-project/cockpituous#594 . I named it that so that it matches the already existing "image-upload" secret. I.e. We declare set of abstract secret names, assign them in the generated tasks ("image-upload", "image-download", "github-token"), and define their "implementation" in the job config.
|
cockpit-project/cockpituous#594 landed and deployed. So I'll land this and retry all the failed rhel* tests that happened over the weekend and today. |
So that job containers can download private images (RHEL). This secret gets defined in cockpit-project/cockpituous#594