ansible: Define "image-download" job secret #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests will need that to download private (RHEL) images from the stores. For now this is the same directory as the upload secret, but at some point we should split them.
martinpitt
added a commit
to cockpit-project/bots
that referenced
this pull request
Mar 11, 2024
So that job containers can download private images (RHEL). This secret gets defined in cockpit-project/cockpituous#594
jelly
approved these changes
Mar 11, 2024
| image-upload=[ | ||
| '--volume=/var/lib/cockpit-secrets/tasks/s3-keys/:/run/secrets/s3-keys:ro', | ||
| '--env=COCKPIT_S3_KEY_DIR=/run/secrets/s3-keys', | ||
| ] | ||
| image-download=[ |
There was a problem hiding this comment.
At first I was a bit confused, as alternative we could have s3-bucket-token. But this might be a bit too much of a bikeshed :)
There was a problem hiding this comment.
The point is that we eventually want to have different tokens for reading (enough for tests) and writing (for image refreshes). So we should name them by purpose. Also, S3 is an implementation detail at this point.
martinpitt
added a commit
to cockpit-project/bots
that referenced
this pull request
Mar 11, 2024
So that job containers can download private images (RHEL). This secret gets defined in cockpit-project/cockpituous#594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests will need that to download private (RHEL) images from the stores.
For now this is the same directory as the upload secret, but at some point we should split them.
This goes along with cockpit-project/bots#6062
I added the secret splitting to the pilot board as enhancement, so that we don't forget.
I did not roll this out yet, will do after review.