-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Fix phpstan expr.resultUnused #9385
refactor: Fix phpstan expr.resultUnused #9385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can go to develop
branch.
I'm afraid of conflicts between branches. If I start with develop, sometimes this has already been changed in 4.6. Can I push in 4.6? |
@neznaika0 we are dealing with try to release 4.6 sooner, if it took some conflict, it can stay here for a while, so next develop already 4.6 so you can change target branch to develop. |
What conflicts are you seeing? |
As a rule, all refactoring should target the lowest branch unless the code in question is present only in the next minor version. |
See changes: #9374 (comment) While I was spending time searching for the cause, the issue was resolved in 4.6 It's not difficult for me to migrate commits. Maybe there is a tip on how to start working with two branches? |
09dd7fc
to
06e47f0
Compare
Well, I'm not aware of that. In such case, what I would maybe do is check if the baselined errors are present in both branches which if then I would target develop. I'm not sure though if that's practical on your part. |
Thanks so far, @neznaika0 , for cleaning up the baseline. |
Description
We just ignore the lines, as we expect an exception.
You can set an assignment
$s = $entity->ninth
, but it seems unnecessary in the test.Checklist: