Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix phpstan expr.resultUnused #9385

Merged
merged 1 commit into from
Jan 8, 2025
Merged

refactor: Fix phpstan expr.resultUnused #9385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/system/Cookie/CookieTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public function testArrayAccessOfCookie(): void
$this->assertSame($cookie['path'], $cookie->getPath());

$this->expectException('InvalidArgumentException');
$cookie['expiry'];
$cookie['expiry']; // @phpstan-ignore expr.resultUnused
}

public function testCannotSetPropertyViaArrayAccess(): void
Expand Down
2 changes: 1 addition & 1 deletion tests/system/Entity/EntityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ public function testCastTimestampException(): void
$entity = $this->getCastEntity();
$entity->ninth = 'some string';

$entity->ninth;
$entity->ninth; // @phpstan-ignore expr.resultUnused
}

public function testCastArray(): void
Expand Down
13 changes: 0 additions & 13 deletions utils/phpstan-baseline/expr.resultUnused.neon
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ includes:
- deadCode.unreachable.neon
- empty.notAllowed.neon
- empty.property.neon
- expr.resultUnused.neon
- function.alreadyNarrowedType.neon
- generator.valueType.neon
- isset.offset.neon
Expand Down
Loading