Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
Jan 13, 2025
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>login</title> | ||
| <title>판다마켓 | 로그인</title> | ||
| <link rel="stylesheet" href="src/assets/css/main.css" /> |
There was a problem hiding this comment.
login page에서 사용되지 않는 스타일이 많이 포함되어있습니다!
페이지별로 스타일을 나누거나 공통 부분을 따로 빼보시면 좋을 거 같아요 :)
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="container"> | ||
| <section class="main-section"> | ||
| <div class="main-section__inner"> | ||
| <div class="main-section__left main-section__left--image"> | ||
| <div class="main-section__left main-section__imagewrap"> |
| </h1> | ||
| <form class="form"> | ||
| <div class="form__group"> | ||
| <label for="email">이메일</label> |
| class="form__input" | ||
| placeholder="비밀번호를 입력해주세요" | ||
| /> | ||
| <div class="visible-icon"></div> |
There was a problem hiding this comment.
아이콘에 대한 정보가 부족해 보여요!
aria-label 등을 통해서 접근성을 높여주시면 좋습니다 :)
There was a problem hiding this comment.
벌써 js를 작성해주셨군요~!
파일명을 좀 더 의미있게 작성해주시면 좋을 거 같습니다 :)
| }); | ||
| }); | ||
|
|
||
| function Check() { |
There was a problem hiding this comment.
일반적으로 js는 카멜 케이스를 많이 사용합니다!
function check {
| }); | ||
| }); | ||
|
|
||
| function Check() { |
There was a problem hiding this comment.
함수명은 명확하게 지어주시는 것이 좋아요! 이 함수는 어떤 것을 check하는 건가요!?
| @@ -0,0 +1,30 @@ | |||
| let visible_icon = document.querySelectorAll(".visible-icon"); | |||
There was a problem hiding this comment.
재할당하지 않는 값들은 const를 씁니다 :)
| @@ -0,0 +1,30 @@ | |||
| let visible_icon = document.querySelectorAll(".visible-icon"); | |||
There was a problem hiding this comment.
일반적으로 js는 카멜 케이스를 많이 사용합니다! const visibleIcons =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게