Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[김성빈] Sprint2 #17

Merged
merged 5 commits into from
Jan 13, 2025
+444 −35
Merged

[김성빈] Sprint2 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3eca6d5
refactor(김동진): 스프린트미션1 코드리뷰 개선사사항 반영
kim-1997 Jan 10, 2025
a221662
refactor(김동진): 스프린트미션1 코드리뷰 개선사항 반영
kim-1997 Jan 10, 2025
f45e997
Merge branch 'Basic-김성빈-sprint2' of https://github.com/kim-1997/14-Sp…
kim-1997 Jan 10, 2025
de20cca
refactor(김동진): 스프린트미션1 코드리뷰 개선사사항 반영-2
kim-1997 Jan 10, 2025
f501d34
refactor(김동진): 스프인트미션2 판다마켓
kim-1997 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="src/assets/css/style.css" />
<link rel="stylesheet" href="src/assets/css/main.css" />
<link rel="stylesheet" href="src/assets/css/font.css" />
<link rel="stylesheet" href="src/assets/css/variables.css" />
<title>판다마켓</title>
</head>
<body>
Expand All @@ -16,32 +17,34 @@ <h1>
<span class="blind">판다마켓</span>
</a>
</h1>
<button>
<div>
<a href="/login.html" class="btn btn--login">
<span>로그인</span>
</a>
</button>
</div>
</div>
</header>
<div class="main-kv">
<div class="main-kv__wrap">
<div class="main-kv__contents">
<h2>
일상의 모든 물건을<br class="mov2" />
거래해 보세요
</h2>
<button class="main-kv__button">
<a href="/items.html" class="btn btn--kv">
<span>구경하러 가기</span>
</a>
</button>
<div class="main-kv__slogan">
<h2>
일상의 모든 물건을<br class="mov2" />
거래해 보세요
</h2>
<div class="main-kv__button">
<a href="/items.html" class="btn btn--kv">
<span>구경하러 가기</span>
</a>
</div>
</div>
</div>
</div>
</div>
<div class="container">
<section class="main-section">
<div class="main-section__inner">
<div class="main-section__left main-section__left--image">
<div class="main-section__left main-section__imagewrap">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bem을 잘 적용해주셨네요! 👍

<div class="main-section__image">
<img
src="src/assets/image/market_img01.jpg"
Expand Down Expand Up @@ -73,7 +76,7 @@ <h3 class="main-section__title">
구매하고 싶은 물품은 검색해서<br />쉽게 찾아보세요
</p>
</div>
<div class="main-section__right main-section__right--image">
<div class="main-section__right main-section__imagewrap">
<div class="main-section__image">
<img
src="src/assets/image/market_img02.jpg"
Expand All @@ -85,7 +88,7 @@ <h3 class="main-section__title">
</section>
<section class="main-section">
<div class="main-section__inner">
<div class="main-section__left main-section__left--image">
<div class="main-section__left main-section__imagewrap">
<div class="main-section__image">
<img
src="src/assets/image/market_img03.jpg"
Expand Down
2 changes: 1 addition & 1 deletion items.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
Expand Down
72 changes: 69 additions & 3 deletions login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,77 @@
<!DOCTYPE html>
<html lang="en">
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>login</title>
<title>판다마켓 | 로그인</title>
<link rel="stylesheet" href="src/assets/css/main.css" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

login page에서 사용되지 않는 스타일이 많이 포함되어있습니다!

페이지별로 스타일을 나누거나 공통 부분을 따로 빼보시면 좋을 거 같아요 :)

<link rel="stylesheet" href="src/assets/css/sub.css" />
<link rel="stylesheet" href="src/assets/css/font.css" />
<link rel="stylesheet" href="src/assets/css/variables.css" />
</head>
<body>
<div>login</div>
<div class="form-box">
<div class="form-box__wrap">
<h1>
<a href="/" class="form-box__logo">
<span class="blind">판다마켓</span>
</a>
</h1>
<form class="form">
<div class="form__group">
<label for="email">이메일</label>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label을 잘 적용해주셨네요! 👍

<input
type="email"
id="email"
class="form__input"
placeholder="이메일을 입력해주세요"
/>
</div>
<div class="form__group">
<label for="password">비밀번호</label>
<div class="form__visible">
<input
type="password"
id="password"
class="form__input"
placeholder="비밀번호를 입력해주세요"
/>
<div class="visible-icon"></div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이콘에 대한 정보가 부족해 보여요!
aria-label 등을 통해서 접근성을 높여주시면 좋습니다 :)

</div>
</div>
<div class="form__group">
<button type="submit" class="form__button">
<span>로그인</span>
</button>
</div>
</form>
<div class="form-box__simplelogin">
<span>간편 로그인 하기</span>
<ul class="form-box__social">
<li>
<a
href="https://www.google.com/"
class="social-icon social-icon--google"
>
<span class="blind">구글 로그인 하기</span>
</a>
</li>
<li>
<a
href="https://www.kakaocorp.com/page/"
class="social-icon social-icon--kakao"
>
<span class="blind">카카오톡 로그인 하기</span>
</a>
</li>
</ul>
</div>
<div class="form-box__signup">
판다마켓이 처음이신가요?
<a href="/signup.html">회원가입</a>
</div>
</div>
</div>
<script src="src/assets/js/sub.js"></script>
</body>
</html>
2 changes: 1 addition & 1 deletion privacy.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
Expand Down
98 changes: 98 additions & 0 deletions signup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다마켓 | 회원가입</title>
<link rel="stylesheet" href="src/assets/css/main.css" />
<link rel="stylesheet" href="src/assets/css/sub.css" />
<link rel="stylesheet" href="src/assets/css/font.css" />
<link rel="stylesheet" href="src/assets/css/variables.css" />
</head>
<body>
<div class="form-box">
<div class="form-box__wrap">
<h1>
<a href="/" class="form-box__logo">
<span class="blind">판다마켓</span>
</a>
</h1>
<form class="form">
<div class="form__group">
<label for="email">이메일</label>
<input
type="email"
id="email"
class="form__input"
placeholder="이메일을 입력해주세요"
/>
</div>
<div class="form__group">
<label for="text">닉네임</label>
<input
type="text"
id="text"
class="form__input"
placeholder="닉네임을 입력해주세요"
/>
</div>
<div class="form__group">
<label for="password">비밀번호</label>
<div class="form__visible">
<input
type="password"
id="password"
class="form__input"
placeholder="비밀번호를 입력해주세요"
/>
<div class="visible-icon visible-icon1"></div>
</div>
</div>
<div class="form__group">
<label for="password2">비밀번호 확인</label>
<div class="form__visible">
<input
type="password"
id="password2"
class="form__input"
placeholder="비밀번호를 다시 한 번 입력해주세요"
/>
<div class="visible-icon visible-icon2"></div>
</div>
</div>
<div class="form__group">
<button type="submit" class="form__button">
<span>회원가입</span>
</button>
</div>
</form>
<div class="form-box__simplelogin">
<span>간편 로그인 하기</span>
<ul class="form-box__social">
<li>
<a
href="https://www.google.com/"
class="social-icon social-icon--google"
>
<span class="blind">구글 로그인 하기</span>
</a>
</li>
<li>
<a
href="https://www.kakaocorp.com/page/"
class="social-icon social-icon--kakao"
>
<span class="blind">카카오톡 로그인 하기</span>
</a>
</li>
</ul>
</div>
<div class="form-box__signup">
이미 회원이신가요?
<a href="/login.html">로그인</a>
</div>
</div>
</div>
<script src="src/assets/js/sub.js"></script>
</body>
</html>
Loading
Loading