DAOS-17271 pool: Fix handle_event -DER_NONEXISTs #16081
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling the exclusion of multiple ranks, pool_svc_update_map_internal aborts the whole request and returns -DER_NONEXIST if any of the ranks is absent in the pool map. This is correct for the dmg case, but problematic for the handle_event case, where ranks not in the pool map should simply be ignored. Signed-off-by: Li Wei <liwei@hpe.com>
|
Ticket title is 'Aurora test cluster can't exclude a faulty engine from a pool: handle_event(): failed to exclude ranks: DER_NONEXIST(-1005): 'The specified entity does not exist'' |
liuxuezhao
approved these changes
Mar 12, 2025
kccain
approved these changes
Mar 12, 2025
| @@ -7033,7 +7033,7 @@ pool_svc_update_map_internal(struct pool_svc *svc, unsigned int opc, bool exclud | |||
| inval_tgt_addrs); | |||
| if (rc != 0) | |||
| goto out_map; | |||
| if (inval_tgt_addrs->pta_number > 0) { | |||
| if (src == MUS_DMG && inval_tgt_addrs->pta_number > 0) { | |||
There was a problem hiding this comment.
If need to revise the patch otherwise: src and skip_rf_check arguments are not documented in the comment preceding the function code. Incidentally, this may be the first and only use of the src argument in this function.
|
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-16081/1/execution/node/1557/log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling the exclusion of multiple ranks,
pool_svc_update_map_internal aborts the whole request and returns -DER_NONEXIST if any of the ranks is absent in the pool map. This is correct for the dmg case, but problematic for the handle_event case, where ranks not in the pool map should simply be ignored. (See the Jira ticket for more.)
Steps for the author:
After all prior steps are complete: