Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17271 pool: Fix handle_event -DER_NONEXISTs #16081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

DAOS-17271 pool: Fix handle_event -DER_NONEXISTs #16081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pool/srv_pool.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7033,7 +7033,7 @@ pool_svc_update_map_internal(struct pool_svc *svc, unsigned int opc, bool exclud
inval_tgt_addrs);
if (rc != 0)
goto out_map;
if (inval_tgt_addrs->pta_number > 0) {
if (src == MUS_DMG && inval_tgt_addrs->pta_number > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If need to revise the patch otherwise: src and skip_rf_check arguments are not documented in the comment preceding the function code. Incidentally, this may be the first and only use of the src argument in this function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

/*
* If any invalid ranks/targets were specified here,
* abort the entire request. This will mean the
Expand Down Expand Up @@ -7604,8 +7604,8 @@ pool_svc_exclude_ranks(struct pool_svc *svc, struct pool_svc_event_set *event_se
NULL, NULL, 0, &list, &inval_list_out, &map_version,
NULL /* hint */, MUS_SWIM, false);

D_DEBUG(DB_MD, "Exclude pool "DF_UUID"/%u ranks %u: rc %d\n",
DP_UUID(svc->ps_uuid), map_version, n, rc);
D_DEBUG(DB_MD, DF_UUID ": exclude %u ranks: map_version=%u: " DF_RC "\n",
DP_UUID(svc->ps_uuid), n, rc == 0 ? map_version : 0, DP_RC(rc));

pool_target_addr_list_free(&inval_list_out);
out:
Expand Down