Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the currently passed-in value for vagovprod to load Medallia scripts. #863

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

timcosgrove
Copy link
Contributor

@timcosgrove timcosgrove commented Jan 9, 2025

Description

The Medallia script responsible for providing feedback button interactivity is not loading on production for Next Build pages.

The problem is that the build script passes in prod as the value for the environment, but Next Build understands vagovprod to be the value for that environment. This is causing the staging script to load. See

const scriptId = process.env.BUILD_TYPE === BUILD_TYPES.PROD ? 2 : 5

This aligns the environment test for prod with the value that is currently being passed in to the build. This will be revisited in another ticket to bring environment usage into consistency: department-of-veterans-affairs/va.gov-cms#20270

Developer Task

Tasks

Preview Give feedback

Testing Steps

This cannot be properly tested until it is in production.

Copy link

@aubreyarcangel aubreyarcangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timcosgrove timcosgrove enabled auto-merge (squash) January 9, 2025 20:04
Copy link

@brianseek brianseek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timcosgrove timcosgrove merged commit cf2af71 into main Jan 9, 2025
10 checks passed
@timcosgrove timcosgrove deleted the tcosgrove-quick_medallia_prod_fix branch January 9, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants