Add a getter isModListOutdated #1633
Conversation
VilppeRiskidev
force-pushed
the
status-indicator-data
branch
from
887f1e5 to
e8cc77f
Compare
VilppeRiskidev
force-pushed
the
status-indicator-data
branch
3 times, most recently
from
a151fd4 to
03a91ea
Compare
src/store/modules/TsModsModule.ts
Outdated
|
|
||
| let conciseError = "Failed to load mod list"; | ||
| if (isNetworkError(state.thunderstoreModListUpdateError)) { | ||
| conciseError = "Failed to download mod list due to network error" |
There was a problem hiding this comment.
Could be "Failed to fully refresh the online mod list due to network error" to be consistent (if screen estate allows).
There was a problem hiding this comment.
Now that you mentioned this, it reminded me that I was also contemplating if the StatusIndicator's text should be a warning or an error (yellow vs. red text), but that's also definitely out of the scope of this PR. :D
There was a problem hiding this comment.
It's a partial failure so I'd say it's an error. Especially since some users seem to be confused about the status unless we're very in-your-face about it.
src/store/modules/TsModsModule.ts
Outdated
| commit('setThunderstoreModListUpdateError', | ||
| new R2Error( | ||
| PARTIAL_UPDATE_ERROR, | ||
| `Only ${chunkCount - successes} out of ${chunkCount} chunks were updated successfully.`, |
There was a problem hiding this comment.
- Bug? Shouldn't this be
Only ${successes} out of ${chunkCount}... - Nitpick but "chunks" might not mean so much to the users. "Parts" would be slightly better? Some other wording could also work.
- If this ends in
., there will be two of them in theImportProfileModal. Fix either here or there, but make sure all places where this is shown show 0..1 full stops. ImportProfileModalandSettingsViewcurrently show this error message. Is that intentional? Looks to mePARTIAL_UPDATE_ERRORis currently shown only if user opens the error modal inModListUpdateBanner, and that might the more user-friendly part of the message. This too can be changed (if it's changed) either here in the error definition, or on the sites where the error is used.
There was a problem hiding this comment.
To comment on the last point: It was/is intentional, but can be changed if you think so.
I think it is nicer this way, because those two places it is prefixed with Error updating the mod list: .
In my opinion Error updating the mod list: Failed to fully refresh the online mod list. Some mod versions might be unavailable. would be a bit redundant, but there could be better wordings for this 🤔 I think it is kind of nice to show the numbers in most cases, but not necessarily on the StatusIndicator if that makes sense (if I was a user and it showed that it downloaded 99 out of 100 parts, I probably would just continue and be aware that something might be a bit broken and 1 success out of 100 would make me expect that it most likely is going to be broken.) That's my $0.02, feel free to ask for more changes.
There was a problem hiding this comment.
Alright, let's go with as-is.
And I think you put more effort in writing the sentences about partial failure than some users will put into the whole thing. Seems to me that for them it's a binary thing, either it failed or it didn't, and the idea of "it didn't go quite as expected but you can try to continue" just doesn't register.
VilppeRiskidev
force-pushed
the
status-indicator-data
branch
2 times, most recently
from
a3bd45d to
b91770a
Compare
VilppeRiskidev
force-pushed
the
status-indicator-data
branch
from
b91770a to
db9d51a
Compare
Reference: https://github.com/thunderstore-io/thunderstore-mod-manager/pull/310