Update status from Splash screen to keep StatusIndicator up to date #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
reviewed
Feb 19, 2025
| @@ -149,7 +149,9 @@ export default class SplashMixin extends Vue { | |||
| this.loadingText = 'Processing the mod list'; | |||
|
|
|||
| try { | |||
| await this.$store.commit('tsMods/startThunderstoreModListUpdate'); | |||
There was a problem hiding this comment.
No need to await commits as they're synchronous.
| await this.$store.dispatch('tsMods/updateMods'); | ||
| await this.$store.commit('tsMods/finishThunderstoreModListUpdate'); |
There was a problem hiding this comment.
I think this should be placed in finally block so the "in progress" status isn't left on if the process fails?
There was a problem hiding this comment.
good point, this doesn't even have to be done on r2mm side...
VilppeRiskidev
force-pushed
the
status-indicator-data
branch
from
a151fd4 to
03a91ea
Compare
VilppeRiskidev
force-pushed
the
status-indicator-index-and-splash-screen
branch
from
f041433 to
450dbc4
Compare
|
New PR replaces this one on TSMM: https://github.com/thunderstore-io/thunderstore-mod-manager/pull/314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.