Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status from Splash screen to keep StatusIndicator up to date #1637

Closed
wants to merge 1 commit into from
Closed

Update status from Splash screen to keep StatusIndicator up to date #1637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/mixins/SplashMixin.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ export default class SplashMixin extends Vue {
this.loadingText = 'Processing the mod list';

try {
await this.$store.commit('tsMods/startThunderstoreModListUpdate');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to await commits as they're synchronous.

await this.$store.dispatch('tsMods/updateMods');
await this.$store.commit('tsMods/finishThunderstoreModListUpdate');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be placed in finally block so the "in progress" status isn't left on if the process fails?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, this doesn't even have to be done on r2mm side...

} catch (e) {
console.error('Updating the store mod list by SplashMixin failed.', e);
} finally {
Expand Down
Loading