Display information about mod list updating being prevented #1646
Conversation
| <div v-if="$store.getters['download/activeDownloadCount'] > 0"> | ||
| <span> | ||
| However, the mod list can't be updated while the are mod downloads in progress. | ||
| Please wait for the downloads to finish before continuing. |
There was a problem hiding this comment.
Just a note: This part will probably be something like "The mod list will try to refresh after the downloads are finished.", or be completely refactored in the future.
There was a problem hiding this comment.
I'd think it will make sense to handle the update before this box is rendered, perhaps in a separate step before the preview. Then in this step we'll either say that some mods can't be imported, or list all the mods normally if they're all known by the manager.
| @@ -32,7 +32,14 @@ export default class ModListUpdateBanner extends Vue { | |||
|
|
|||
| <template> | |||
| <div v-if="!isModListLoaded" id="mod-list-update-banner" class="margin-bottom"> | |||
| <div class="notification is-warning margin-right"> | |||
| <div v-if="$store.getters['download/activeDownloadCount'] > 0" class="notification is-warning margin-right"> | |||
There was a problem hiding this comment.
How certain are you about the placement of this if-block? My gut feeling says it would make more sense to have it second last (before the option to update the mod list).
| <div class="notification is-warning margin-right"> | ||
| <div v-if="$store.getters['download/activeDownloadCount'] > 0" class="notification is-warning margin-right"> | ||
| <span> | ||
| An error occurred when updating the mod list from Thunderstore.<br /> |
There was a problem hiding this comment.
Nitpick: since this component was created I've moved to trying to use "refresh the online mod list" to keep the UI texts consistent. Wouldn't hurt to update this component. This applies to ImportProfileModal too.
| <div v-if="$store.getters['download/activeDownloadCount'] > 0"> | ||
| <span> | ||
| However, the mod list can't be updated while the are mod downloads in progress. | ||
| Please wait for the downloads to finish before continuing. |
There was a problem hiding this comment.
I'd think it will make sense to handle the update before this box is rendered, perhaps in a separate step before the preview. Then in this step we'll either say that some mods can't be imported, or list all the mods normally if they're all known by the manager.
| @@ -314,6 +314,9 @@ import CdnProvider from '../../providers/generic/connection/CdnProvider'; | |||
| 'Refresh online mod list', | |||
| 'Check for any new mod releases.', | |||
| async () => { | |||
| if (this.$store.getters['download/activeDownloadCount'] > 0) { | |||
There was a problem hiding this comment.
Here too it might make sense to prefer to show the current status of update if mod downloads and mod list refresh are going on at the same time. Note that while the refresh can't be started while mods are downloading, user can still start downloads while the refresh is in progress, so both can be happening in the same time.
VilppeRiskidev
changed the base branch from
prevent-update-when-downloading
to
status-indicator-data
…re are downloads in progress
VilppeRiskidev
force-pushed
the
mod-list-update-prevent-info
branch
from
49bfdc2 to
133c5a9
Compare
Display information about mod list updating being prevented while there are downloads in progress