-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binding-opcua:test fix macOS endpoint #1141
binding-opcua:test fix macOS endpoint #1141
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
=======================================
Coverage 77.12% 77.13%
=======================================
Files 80 80
Lines 16296 16296
Branches 1552 1552
=======================================
+ Hits 12569 12570 +1
+ Misses 3705 3704 -1
Partials 22 22 ☔ View full report in Codecov by Sentry. |
df6a573
to
40af85e
Compare
@erossignon Thank you very much for looking into the issue. As mentioned before I cannot run the opcua tests on Windows either since a while. Seems related to some company network settings.
For the record and maybe to help others as well.
and the opcua tests are working again 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
referring to the issue might help others understand the reason
2a2faca
to
f547ec7
Compare
f547ec7
to
e5c8dc0
Compare
e5c8dc0
to
5759048
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
No description provided.