Integration Testing Framework: Add retries for artifacts API call #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
Team:Elastic-Agent
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
NOTE: |
ycombinator
added
backport-v8.13.0
ycombinator
force-pushed
the
testing-artifacts-api-retries
branch
2 times, most recently
from
e12ace2 to
e7af558
Compare
ycombinator
force-pushed
the
testing-artifacts-api-retries
branch
from
e7af558 to
0805f66
Compare
|
Moving PR into draft to a) update unit test assertions and b) refactor logging logic so logger doesn't need to be passed down in several places. |
cmacknz
reviewed
Mar 4, 2024
ycombinator
force-pushed
the
testing-artifacts-api-retries
branch
from
adf118f to
6306b23
Compare
cmacknz
approved these changes
Mar 4, 2024
|
0.0% Duplication on New Code
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
) * Add retries for artifacts API call * Add newline * Adding logging * Pass logger in constructor * Add missing arg * Fix logic for happy path * Adding comment * Do not keep retrying if request context was cancelled or timed out (cherry picked from commit 94c7d88)
rdner
reviewed
Mar 5, 2024
There was a problem hiding this comment.
@ycombinator Unfortunately, I didn't look at this PR in time. Sorry about that.
I don't think this is how we should approach it, we should:
- Implement the
httpDoerinterface with retries and use this implementation as an option - Continue using the existing option pattern and remove the logger parameter.
- The logger interface is not implemented by any logger, only by
testing.Tand this client is used beyond testing.
I addressed 2 and 3 in my PR #4331 (had to resolve some conflicts)
ycombinator
added a commit
that referenced
this pull request
Mar 7, 2024
) * Add retries for artifacts API call * Add newline * Adding logging * Pass logger in constructor * Add missing arg * Fix logic for happy path * Adding comment * Do not keep retrying if request context was cancelled or timed out (cherry picked from commit 94c7d88)
ycombinator
added a commit
that referenced
this pull request
Mar 7, 2024
) (#4353) * Add retries for artifacts API call * Add newline * Adding logging * Pass logger in constructor * Add missing arg * Fix logic for happy path * Adding comment * Do not keep retrying if request context was cancelled or timed out (cherry picked from commit 94c7d88) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds retries to the Artifacts API call in the integration testing framework, as recommended by @DaveSys911.
Why is it important?
The Artifacts API can sometimes be flaky.
Related issues