Use the public product versions API for creating the versions list #4423
Conversation
rdner
added
Team:Elastic-Agent
rdner
force-pushed
the
fetch-versions-from-public-source
branch
4 times, most recently
from
6ea9ea0 to
388afd0
Compare
Replacing the artifact API with the more stable source.
rdner
force-pushed
the
fetch-versions-from-public-source
branch
from
388afd0 to
b17b3ac
Compare
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
| // uncomment if want to have the current version snapshot on the list as well | ||
| // branches = append([]string{"master"}, branches...) |
There was a problem hiding this comment.
It's not necessary to have the current version snapshot on this list because we have plenty of tests that use it for upgrade/downgrade already. So, I skipped it to make the tests run faster.
| @@ -156,26 +136,10 @@ func NewArtifactAPIClient(opts ...ArtifactAPIClientOpt) *ArtifactAPIClient { | |||
| return c | |||
| } | |||
|
|
|||
| // GetVersions returns a list of versions as server by the Artifact API along with some aliases and manifest information | |||
There was a problem hiding this comment.
I understand that this function and the types above are not used by the new version of testing code but they are still existing operations and types of Artifact API, I would prefer to leave them there
There was a problem hiding this comment.
The artifact API is deprecated and we must eventually get rid of it entirely. Deleting these functions will make sure we're not using them again.
There was a problem hiding this comment.
Since the datamodel is shared with the DRA manifests we need to make sure we don't delete too much.
As for this client, it was not about what we have to use in the tests, just a simple client that made accessing the snapshot API easier regardless of how it has been used. For the deprecation a simple Deprecated: comment on the client itself would suffice.
|
0.0% Duplication on New Code
What does this PR do?
Replacing the artifact API with the more stable source.
Why is it important?
So, our versions list file is compiled with valid/published versions.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry in./changelog/fragmentsusing the changelog tool- [ ] I have added an integration test or an E2E testHow to test this PR locally
Related issues