-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pbkdf2 settings validation is FIPS compliant #4542
Merged
michel-laterman
merged 2 commits into
elastic:main
from
michel-laterman:fips-pbkdf2-validate
Mar 5, 2025
Merged
pbkdf2 settings validation is FIPS compliant #4542
michel-laterman
merged 2 commits into
elastic:main
from
michel-laterman:fips-pbkdf2-validate
Mar 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
reviewed
Mar 4, 2025
|
blakerouse
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
kaanyalti
approved these changes
Mar 5, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Validate pbkdf2 settings are FIPS compliant (cherry picked from commit 63b6b92)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Validate pbkdf2 settings are FIPS compliant (cherry picked from commit 63b6b92) # Conflicts: # internal/pkg/config/pbkdf2.go
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
Validate pbkdf2 settings are FIPS compliant (cherry picked from commit 63b6b92)
3 tasks
michel-laterman
added a commit
that referenced
this pull request
Mar 6, 2025
michel-laterman
added a commit
that referenced
this pull request
Mar 6, 2025
michel-laterman
added a commit
that referenced
this pull request
Mar 10, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.18
Automated backport to the 8.18 branch
backport-9.0
Automated backport to the 9.0 branch
enhancement
New feature or request
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
User pbkdf2 settings are not validated for FIPS compliance.
How does this PR solve the problem?
Validate pbkdf2 settings.
Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog tool