Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature statuses for EDOT Node.js #121

Merged
merged 8 commits into from
Mar 21, 2025
Merged

Conversation

trentm
Copy link
Member

@trentm trentm commented Mar 20, 2025

Refs: #118

@trentm trentm self-assigned this Mar 20, 2025
@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100

*TBD

@@ -10,7 +10,7 @@ features:
min_version: 1.0
Node.js:
status: ga
min_version: 1.0
min_version: "0.2.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review note: I'm fine moving this back to 1.0 if the aesthetics are better in the table. No one is ever going to use old version 0.2.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, let's move it back to 1.0 (I think we can ignore the pre-GA versions in this table)

@@ -158,8 +158,8 @@ features:
status: ga
min_version:
Node.js:
status: ga
min_version:
status: tech-preview
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review note: The Logs API, Logs SDK, and instrumentations of logging libraries are still experimental in upstream OTel JS, so I was hesitant to call this "GA" in EDOT Node.js. Same for the log correlation below.

@trentm trentm mentioned this pull request Mar 20, 2025
7 tasks
@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100
docs/_edot-sdks/index.md 69 37 46 37

*TBD

@trentm trentm requested a review from hegerchr March 20, 2025 22:25
@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100
docs/_edot-sdks/index.md 69 37 46 37

*TBD

@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100
docs/_edot-sdks/index.md 69 37 46 37

*TBD

@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100
docs/_edot-sdks/index.md 69 37 46 37

*TBD

@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100
docs/_edot-sdks/index.md 69 37 46 37

*TBD

AlexanderWert
AlexanderWert previously approved these changes Mar 21, 2025
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100
docs/_edot-sdks/index.md 69 31 48 39

*TBD

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/_edot-sdks/features.yml 78 66 2 100
docs/_edot-sdks/index.md 69 31 48 39

*TBD

@AlexanderWert AlexanderWert merged commit a6feaac into main Mar 21, 2025
2 of 3 checks passed
@trentm
Copy link
Member Author

trentm commented Mar 24, 2025

Holy, Acrolinx Scorecards, Batman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants