Updates CLI tests code based on the PR comments #4075
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![codefactor-io[bot]](https://avatars.githubusercontent.com/in/25603?s=60&v=4){kind=small}
packages/cli/src/server/api/agent.ts
Outdated
| }); | ||
| } | ||
|
|
||
| let results = []; |
There was a problem hiding this comment.
'results' is never reassigned. Use 'const' instead.
| let results = []; | |
| const results = []; |
packages/cli/src/server/api/agent.ts
Outdated
| } | ||
|
|
||
| let results = []; | ||
| let errors = []; |
There was a problem hiding this comment.
'errors' is never reassigned. Use 'const' instead.
| let errors = []; | |
| const errors = []; |
packages/cli/src/utils/get-config.ts
Outdated
| await ensureEnvFile(envFilePath); | ||
|
|
||
| // Check if we already have database configuration in env | ||
| let postgresUrl = process.env.POSTGRES_URL; |
There was a problem hiding this comment.
'postgresUrl' is never reassigned. Use 'const' instead.
| let postgresUrl = process.env.POSTGRES_URL; | |
| const postgresUrl = process.env.POSTGRES_URL; |
| if (isLoading || isError || !agents || !agents.length || !roomsData) { | ||
| return; | ||
| } | ||
| let activeAgentIds: UUID[] = []; |
There was a problem hiding this comment.
'activeAgentIds' is never reassigned. Use 'const' instead.
| let activeAgentIds: UUID[] = []; | |
| const activeAgentIds: UUID[] = []; |
packages/core/src/actions/roles.ts
Outdated
| let worldUpdated = false; | ||
|
|
||
| for (const assignment of result) { | ||
| let targetEntity = entities.find((e) => e.id === assignment.entityId); |
There was a problem hiding this comment.
'targetEntity' is never reassigned. Use 'const' instead.
| let targetEntity = entities.find((e) => e.id === assignment.entityId); | |
| const targetEntity = entities.find((e) => e.id === assignment.entityId); |
packages/core/src/runtime.ts
Outdated
| /** | ||
| * Initialize an empty object for storing environment settings. | ||
| */ | ||
| let environmentSettings: Settings = {}; |
There was a problem hiding this comment.
'environmentSettings' is never reassigned. Use 'const' instead.
| let environmentSettings: Settings = {}; | |
| const environmentSettings: Settings = {}; |
packages/core/src/runtime.ts
Outdated
| // Step 1: Handle entity creation/update with proper error handling | ||
| try { | ||
| // First check if the entity exists | ||
| let entity = await this.adapter.getEntityById(entityId); |
There was a problem hiding this comment.
'entity' is never reassigned. Use 'const' instead.
| let entity = await this.adapter.getEntityById(entityId); | |
| const entity = await this.adapter.getEntityById(entityId); |
| @@ -38,7 +38,10 @@ | |||
| "lint": "prettier --write ./src", | |||
| "format": "prettier --write ./src", | |||
| "format:check": "prettier --check ./src", | |||
| "clean": "rm -rf dist .turbo node_modules .turbo-tsconfig.json tsconfig.tsbuildinfo" | |||
| "clean": "rm -rf dist .turbo node_modules .turbo-tsconfig.json tsconfig.tsbuildinfo", | |||
| "test:setup-commands": "vitest test/setup-commands.test.js", | |||
There was a problem hiding this comment.
we should probably create a command to run each of these with the && sign on so like a test:cli one
| export const agent2Name = 'test-agent2'; | ||
| export const commands = ['create', 'start', 'agent', 'plugin', 'env']; | ||
| export const invalidName = '!invalid@name'; | ||
| export const characters = [ |
There was a problem hiding this comment.
looks great thanks for adding this file
|
Once we get it working 100% we will want to add this as a workflow that runs on PRs called cli-tests can be a follow up just flagging this |
Relates to
Sifchain#394
Risks
Background
What does this PR do?
Updates CLI tests code based on the PR comments in #4060
What kind of change is this?
Created a utils/constants file and moved all constants to it.
Replaced console logs with elizaLogger
Minor changes like adding errors to exceptions or repalcing .log with .error
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps
Testcase results