Enhance start habilitation #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a 2 step process now: 1. Organization verification 2. Choose the form We can customize for each authorization the second page. The second page is optional if there's only one form.
Still WIP, can be fixed later
skelz0r
force-pushed
the
features/enhance-start-habilitation
branch
3 times, most recently
from
905a034 to
433358a
Compare
With some enhancements
Will be used in decision tree
Put default as last element for definition.
tags will be used within views for decision trees, it is not an actual model attribute
* Share complexe config between rspec and cucumber for docker/CI tests * Harden web steps too, not so efficient with basic capybara features
* Introduce stimulus controller to handle the basic decision tree => Use tags to filter forms (thanks to previous commits) * New card decision for start (use a data-turbo-method, which is not a so great solution, but hey it works with the DSFR) * Activate js in cucumber to be sure that is works (without js it works too because it does not handle fr-hidden well with rack test)
skelz0r
force-pushed
the
features/enhance-start-habilitation
branch
from
709a62b to
2c664be
Compare
Have to change all cucumber steps for "Démarrer" (which is "Débuter" now)
skelz0r
force-pushed
the
features/enhance-start-habilitation
branch
from
2c664be to
34636cf
Compare
skelz0r
force-pushed
the
features/enhance-start-habilitation
branch
from
f9ed1e5 to
4475123
Compare
Un3x
approved these changes
Jan 30, 2024
Isalafont
approved these changes
Jan 30, 2024
skelz0r
force-pushed
the
features/enhance-start-habilitation
branch
from
93f1b9a to
ebe70a6
Compare
skelz0r
force-pushed
the
features/enhance-start-habilitation
branch
from
ebe70a6 to
65a6bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_case-> filtrer directementCloses https://linear.app/pole-api/issue/API-2117/page-de-demarrage-dhabilitation