x86: pass through cpuid leaves 15h and 16h #5186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5186 +/- ##
=========================================================
+ Coverage 82.64% 82.66% +0.01%
=========================================================
Files 250 250
Lines 27296 27332 +36
=========================================================
+ Hits 22559 22593 +34
- Misses 4737 4739 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
reviewed
May 6, 2025
roypat
force-pushed
the
frequency-passthrough
branch
2 times, most recently
from
05d11e8 to
67b36b8
Compare
kalyazin
reviewed
May 6, 2025
Turn the three error variants that had a cpuid leaf number hardcoded in their name into a single generic LeafMissing(usize) error variant. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
These leaves communicate TSC and CPU frequencies to the guest, and are used by the guest as a preferred means of calibration. This is especially important in secret-free contexts, where kvm-clock is not available (so guest cannot get TSC frequency from there), and calibration against PIT is unreliable. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
frequency-passthrough
branch
from
3b4d75f to
f1575cb
Compare
kalyazin
approved these changes
May 6, 2025
JackThomson2
approved these changes
May 6, 2025
Manciukic
approved these changes
May 6, 2025
roypat
merged commit 870b5cb
into
firecracker-microvm:feature/secret-hiding
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These leaves communicate TSC and CPU frequencies to the guest, and
are used by the guest as a preferred means of calibration. This is
especially important in secret-free contexts, where kvm-clock is not
available (so guest cannot get TSC frequency from there), and
calibration against PIT is unreliable.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.