Fix Project Dialog Removing Home Dir. from Project Path #101609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DubiousDuck
force-pushed
the
project_dialog_fix
branch
from
beb0222 to
ab3b434
Compare
DubiousDuck
force-pushed
the
project_dialog_fix
branch
from
ab3b434 to
6c276c7
Compare
|
I believe this would be superseded by #95262 if that gets merged |
|
Oh yeah seems like it. I will make the necessary changes (if at all needed) to this commit if the other one gets merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101528
Code changes are made in the editor/project_manager/project_dialog.cpp file.
Since the error is only an issue when the home directory is removed by the script, I added an
ifstatement to check if the target path is equal to the home directory (or the documents directory). The script then only removes the last file path if the path is not.Since the same if statement is also used in
_validate_path(), I extracted the statement and created a separate boolean function_is_path_home_or_doc_dir(const String &p_path).Please let me know if looks good. Thanks!