Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate global code for VisualShader nodes that connect to VaryingSetters #101648

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

aaronp64
Copy link
Contributor

Updated visual shader code to call generate_global_per_node() for nodes connected to VaryingSetter nodes, even if they don't connect directly to Output.

Fixes #101085

…tters

Updated visual shader code to call generate_global_per_node() for nodes connected to VaryingSetter nodes, even if they don't connect directly to Output.
@aaronp64 aaronp64 requested a review from a team as a code owner January 16, 2025 20:25
@Chaosus Chaosus added this to the 4.4 milestone Jan 17, 2025
Copy link
Member

@Chaosus Chaosus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, LGTM

@Repiteo Repiteo merged commit 0cbcfb3 into godotengine:master Jan 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 20, 2025

Thanks!

@aaronp64 aaronp64 deleted the varyingsetter_global_per_node branch March 6, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RandomRange VisualShader Node throws error when connected to Varying Setter
3 participants