Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build profile project detection also set build options #103719

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YeldhamDev
Copy link
Member

@YeldhamDev YeldhamDev commented Mar 6, 2025

Currently, the build profile editor only updates the used classes when attempting to detect from the project. This PR makes so that the other settings are also updated from the project information with the following.

  • Checking project settings.
  • Checking classes that require them.
  • And last but definitely not least, import settings. This one required me to add an extra functionality called get_build_dependencies(), that works like get_classes_used() but is geared towards resource importers. And just like the latter, the former is also exposed to scripting.

However, that are a couple of build options that I couldn't find a way to detect, because as far as I'm aware, there are no settings that could imply if the project is using them or not:

  • X11/Wayland.
  • SIL Graphite Fonts

This PR is also in draft mode for now, as it assumes the existence of build options from other PRs of mine that haven't been merged yet.

Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.

@Riteo
Copy link
Contributor

Riteo commented Mar 9, 2025

X11/Wayland.

Isn't there a platform-specific display driver option somewhere in the project settings? I think you could use that to at least add the default driver. Although arguably it would make more sense to keep both by default I think, from a compatibility perspective.

@YeldhamDev YeldhamDev force-pushed the build_detection_improvements branch from ef2ba69 to fe10992 Compare March 9, 2025 01:30
@YeldhamDev
Copy link
Member Author

@Riteo Yep, missed that setting. If it's set to default, both are now selected, otherwise, it will be the one you picked.

@YeldhamDev YeldhamDev force-pushed the build_detection_improvements branch from 64b1e52 to 7bcbe7d Compare March 12, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants