-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noto Serif Hentaigana: Version 1.000 added #7327
Conversation
* Noto Serif Hentaigana Version 1.000 taken from the upstream repo https://github.com/notofonts/hentaigana.git at commit https://github.com/notofonts/hentaigana/commit/.
This comment was marked as outdated.
This comment was marked as outdated.
This is a new font family to cover the Kana Extended unicode block. I'm fairly sure the name length failure is not a problem because this VF has its default position at extra light. ExtraLight should not be added to the instance name, so all is good. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.11.2 Check results[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[16] NotoSerifHentaigana[wght].ttf🔥 FAIL: Combined length of family and style must not exceed 32 characters. (com.google.fonts/check/name/family_and_style_max_length)
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Does the font contain less than 150 CJK characters? (com.google.fonts/check/cjk_not_enough_glyphs)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check that legacy accents aren't used in composite glyphs. (com.google.fonts/check/legacy_accents)
⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 310: ⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́ Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Gulay (Latn, 250,478 speakers), Ngbaka (Latn, 1,020,000 speakers), Kom (Latn, 360,685 speakers), Mundani (Latn, 34,000 speakers), Dii (Latn, 71,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Dan (Latn, 1,099,244 speakers), Aghem (Latn, 38,843 speakers), Mfumte (Latn, 79,000 speakers), Ma’di (Latn, 584,000 speakers), Zapotec (Latn, 490,000 speakers), Nzakara (Latn, 50,000 speakers), Bafut (Latn, 158,146 speakers), Ebira (Latn, 2,200,000 speakers), Koonzime (Latn, 40,000 speakers), Avokaya (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Cicipu (Latn, 44,000 speakers), Lugbara (Latn, 2,200,000 speakers), Southern Kisi (Latn, 360,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Basaa (Latn, 332,940 speakers), Ejagham (Latn, 120,000 speakers), South Central Banda (Latn, 244,000 speakers), Sar (Latn, 500,000 speakers), Fur (Latn, 1,230,163 speakers), Nateni (Latn, 100,000 speakers), Ekpeye (Latn, 226,000 speakers), Yala (Latn, 200,000 speakers), Makaa (Latn, 221,000 speakers), Igbo (Latn, 27,823,640 speakers), Mango (Latn, 77,000 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Font follows the family naming recommendations? (com.google.fonts/check/family_naming_recommendations)
Summary
Note: The following loglevels were omitted in this report:
|
This will probably need subset work. |
@simoncozens I see that the subset issue is solved! |
Yes please! |
Status:When I added the subset 'kana-extended', it broke the dev-server. Garret fixed that, and re-pushed the subset update.
However, I still see that in the dev-server: @simoncozens Do you know if we need language option like |
Sample text PR: #8013. The kana extended subset definition looks correct. Eng may need to repush. @garretrieger @nathan-williams |
We included this in the to_sandbox list and will check subsetting again following the sandbox push. |
Hi @garretrieger, @nathan-williams The target script is not shown consistently in the Sandbox server.
We consider all the necessary pieces to have been fulfilled. Could you please assist us in understanding the situation with it? Is there anything else needed from our side for the font to show up correctly in the UI?
|
@nyshadhr9, if you have time to take a look at this :) |
What is the status here? |
Status: We now have tofu everywhere (dev-sandbox + sandbox) cc @rsheeter |
Update: this PR should solve it! |
@rsheeter This does point to some weirdness in the API, where if a font has both |
This is now behaving nicely in dev, can go to sandbox please! |
ae3761d: [gftools-packager] Noto Serif Hentaigana: Version 1.000 added