Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noto Serif Hentaigana: Version 1.000 added #7327

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

simoncozens
Copy link
Collaborator

ae3761d: [gftools-packager] Noto Serif Hentaigana: Version 1.000 added

This comment was marked as outdated.

@simoncozens simoncozens marked this pull request as ready for review February 27, 2024 08:52
@simoncozens
Copy link
Collaborator Author

This is a new font family to cover the Kana Extended unicode block.

I'm fairly sure the name length failure is not a problem because this VF has its default position at extra light. ExtraLight should not be added to the instance name, so all is good.

This comment was marked as outdated.

@emmamarichal emmamarichal added II CJK Chinese, Japanese, Korean scripts I New Font labels Feb 28, 2024
@emmamarichal emmamarichal self-requested a review February 28, 2024 14:07

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.11.2

Check results

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[16] NotoSerifHentaigana[wght].ttf
🔥 FAIL: Combined length of family and style must not exceed 32 characters. (com.google.fonts/check/name/family_and_style_max_length)
  • 🔥 FAIL Variable font instance name 'ExtraLight Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 268 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'ExtraLight Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 268 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Light Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 269 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Light Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 269 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Regular Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 270 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Regular Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 270 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Medium Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 271 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Medium Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 271 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'SemiBold Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 272 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'SemiBold Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 272 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Bold Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 273 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Bold Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 273 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'ExtraBold Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 274 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'ExtraBold Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 274 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Black Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 275 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • 🔥 FAIL Variable font instance name 'Black Noto Serif Hentaigana ExtraLight' formed by space-separated concatenation of instance subfamily nameID 275 and font family name (nameID 1) exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]

  • WARN Name ID 6 'NotoSerifHentaigana-ExtraLight' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms. [code: nameid6-too-long]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0020 SPACE: try adding one of: warang-citi, arabic, lydian, canadian-aboriginal, avestan, pahawh-hmong, egyptian-hieroglyphs, medefaidrin, elbasan, wancho, ugaritic, mongolian, chinese-hongkong, psalter-pahlavi, kharoshthi, chinese-simplified, old-sogdian, mandaic, old-hungarian, multani, music, osage, coptic, saurashtra, kannada, mende-kikakui, cherokee, makasar, syriac, new-tai-lue, takri, meroitic-hieroglyphs, mahajani, greek, yezidi, buginese, gothic, ol-chiki, tirhuta, old-turkic, soyombo, hanunoo, inscriptional-pahlavi, symbols, tai-le, cypriot, pau-cin-hau, tibetan, elymaic, old-permic, samaritan, tagbanwa, math, gujarati, sora-sompeng, signwriting, shavian, bassa-vah, siddham, ethiopic, gunjala-gondi, grantha, marchen, runic, hebrew, khitan-small-script, khojki, imperial-aramaic, lepcha, limbu, balinese, dives-akuru, tangut, phoenician, syloti-nagri, nyiakeng-puachue-hmong, lisu, tagalog, linear-a, malayalam, cypro-minoan, cyrillic, inscriptional-parthian, sharada, tamil-supplement, bengali, greek-ext, hatran, osmanya, znamenny, khmer, ottoman-siyaq-numbers, bamum, deseret, caucasian-albanian, javanese, thai, batak, manichaean, tai-tham, kaithi, newa, ahom, glagolitic, meetei-mayek, tifinagh, khudawadi, mayan-numerals, zanabazar-square, yi, palmyrene, georgian, thaana, cham, korean, phags-pa, cuneiform, kawi, tamil, nushu, chakma, meroitic-cursive, masaram-gondi, kayah-li, vietnamese, buhid, meroitic, linear-b, sundanese, lao, nandinagari, armenian, toto, nko, brahmi, vai, anatolian-hieroglyphs, hanifi-rohingya, mro, cyrillic-ext, myanmar, modi, nabataean, devanagari, sogdian, braille, telugu, old-north-arabian, ogham, tai-viet, bhaiksuki, duployan, oriya, old-italic, lycian, miao, vithkuqi, adlam, chorasmian, old-uyghur, nag-mundari, japanese, rejang, tangsa, gurmukhi, old-south-arabian, old-persian, sinhala, chinese-traditional, carian, dogra, indic-siyaq-numbers

  • U+00A0 NO-BREAK SPACE: try adding one of: warang-citi, arabic, lydian, canadian-aboriginal, avestan, pahawh-hmong, egyptian-hieroglyphs, medefaidrin, elbasan, wancho, ugaritic, mongolian, chinese-hongkong, psalter-pahlavi, kharoshthi, chinese-simplified, old-sogdian, mandaic, old-hungarian, multani, music, osage, coptic, saurashtra, kannada, mende-kikakui, cherokee, makasar, syriac, new-tai-lue, takri, meroitic-hieroglyphs, mahajani, greek, yezidi, buginese, gothic, ol-chiki, tirhuta, old-turkic, soyombo, hanunoo, inscriptional-pahlavi, symbols, tai-le, cypriot, pau-cin-hau, tibetan, elymaic, old-permic, samaritan, tagbanwa, math, gujarati, sora-sompeng, signwriting, shavian, bassa-vah, siddham, ethiopic, gunjala-gondi, grantha, marchen, runic, hebrew, khitan-small-script, khojki, imperial-aramaic, lepcha, limbu, balinese, dives-akuru, tangut, phoenician, syloti-nagri, nyiakeng-puachue-hmong, lisu, tagalog, linear-a, malayalam, cypro-minoan, cyrillic, inscriptional-parthian, sharada, tamil-supplement, bengali, greek-ext, hatran, osmanya, znamenny, khmer, ottoman-siyaq-numbers, bamum, deseret, caucasian-albanian, javanese, thai, batak, manichaean, tai-tham, kaithi, newa, ahom, glagolitic, meetei-mayek, tifinagh, khudawadi, mayan-numerals, zanabazar-square, yi, palmyrene, georgian, thaana, cham, korean, phags-pa, cuneiform, kawi, tamil, nushu, chakma, meroitic-cursive, masaram-gondi, kayah-li, vietnamese, buhid, meroitic, linear-b, sundanese, lao, nandinagari, armenian, toto, nko, brahmi, vai, anatolian-hieroglyphs, hanifi-rohingya, mro, cyrillic-ext, myanmar, modi, nabataean, devanagari, sogdian, braille, telugu, old-north-arabian, ogham, tai-viet, bhaiksuki, duployan, oriya, old-italic, lycian, miao, vithkuqi, adlam, chorasmian, old-uyghur, nag-mundari, japanese, rejang, tangsa, gurmukhi, old-south-arabian, old-persian, sinhala, chinese-traditional, carian, dogra, indic-siyaq-numbers

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, tifinagh, coptic

  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
    300 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu [code: unreachable-subsetting]

WARN: Does the font contain less than 150 CJK characters? (com.google.fonts/check/cjk_not_enough_glyphs)
  • WARN There are only 2 CJK glyphs when there needs to be at least 150 in order to support the smallest CJK writing system, Kana.
    The following CJK glyphs were found:
    ['uni3099', 'uni309A']
    Please check that these glyphs have the correct unicodes. [code: cjk-not-enough-glyphs]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check that legacy accents aren't used in composite glyphs. (com.google.fonts/check/legacy_accents)
  • WARN Glyph "Aacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Abreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Acircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Adieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Agrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Aogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Atilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Cacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ccaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Cdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Dcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Eacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ecaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ecircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Edieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Edotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Egrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Gbreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Gdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Iacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Icircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Idieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Idotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Igrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Lacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Nacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ncaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ntilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Oacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ocircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Odieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ograve" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ohungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Otilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Racute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Rcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Sacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Scaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Scedilla" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Tcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Uacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ubreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ucircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Udieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ugrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Uhungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Uring" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Wacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Wcircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Wdieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Wgrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Yacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ycircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ydieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Ygrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Zacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Zcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "Zdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "aacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "abreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "acircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "acutecomb" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "adieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "agrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "aogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "aring" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "atilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uni0306" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "cacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uni030C" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ccaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ccedilla" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "cdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uni0302" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uni0308" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uni0307" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "eacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ecaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ecircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "edieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "edotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "egrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "gbreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "gdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "gravecomb" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uni030B" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "iacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "icircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "idieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "igrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "lacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "nacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ncaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ntilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "oacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ocircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "odieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ograve" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ohungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "otilde" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "racute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "rcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uni030A" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "sacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "scaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "scedilla" has a legacy accent component (cedilla). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "tildecomb" has a legacy accent component (tilde). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ubreve" has a legacy accent component (breve). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ucircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "udieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ugrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uhungarumlaut" has a legacy accent component (hungarumlaut). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uogonek" has a legacy accent component (ogonek). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "uring" has a legacy accent component (ring). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "wacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "wcircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "wdieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "wgrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "yacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ycircumflex" has a legacy accent component (circumflex). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ydieresis" has a legacy accent component (dieresis). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "ygrave" has a legacy accent component (grave). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "zacute" has a legacy accent component (acute). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "zcaron" has a legacy accent component (caron). It needs to be replaced by a combining mark. [code: legacy-accents-component]
  • WARN Glyph "zdotaccent" has a legacy accent component (dotaccent). It needs to be replaced by a combining mark. [code: legacy-accents-component]
WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
  • WARN The most common width is 559 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 310:
minus
[code: width-outliers]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Gulay (Latn, 250,478 speakers), Ngbaka (Latn, 1,020,000 speakers), Kom (Latn, 360,685 speakers), Mundani (Latn, 34,000 speakers), Dii (Latn, 71,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Dan (Latn, 1,099,244 speakers), Aghem (Latn, 38,843 speakers), Mfumte (Latn, 79,000 speakers), Ma’di (Latn, 584,000 speakers), Zapotec (Latn, 490,000 speakers), Nzakara (Latn, 50,000 speakers), Bafut (Latn, 158,146 speakers), Ebira (Latn, 2,200,000 speakers), Koonzime (Latn, 40,000 speakers), Avokaya (Latn, 100,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Cicipu (Latn, 44,000 speakers), Lugbara (Latn, 2,200,000 speakers), Southern Kisi (Latn, 360,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Basaa (Latn, 332,940 speakers), Ejagham (Latn, 120,000 speakers), South Central Banda (Latn, 244,000 speakers), Sar (Latn, 500,000 speakers), Fur (Latn, 1,230,163 speakers), Nateni (Latn, 100,000 speakers), Ekpeye (Latn, 226,000 speakers), Yala (Latn, 200,000 speakers), Makaa (Latn, 221,000 speakers), Igbo (Latn, 27,823,640 speakers), Mango (Latn, 77,000 speakers). [code: soft-dotted]

INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/notoserifhentaigana/NotoSerifHentaigana[wght].ttf
Dehinted Size 443.9kb
Hinted Size 444.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/notoserifhentaigana [code: family-path]
INFO: Font follows the family naming recommendations? (com.google.fonts/check/family_naming_recommendations)
  • INFO Font does not follow some family naming recommendations:
Field Value Recommendation
Family Name Noto Serif Hentaigana ExtraLight exceeds max length (31)
[code: bad-entries]

Summary

💔 ERROR ☠ FATAL 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 1 7 49 9 194 0
0% 0% 0% 3% 19% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal merged commit b4d2645 into main Mar 6, 2024
6 of 7 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_notoserifhentaigana branch March 6, 2024 09:33
@simoncozens
Copy link
Collaborator Author

This will probably need subset work.

@emmamarichal
Copy link
Collaborator

Ah, indeed!

Screenshot 2024-03-06 at 12 06 29

@emmamarichal
Copy link
Collaborator

@simoncozens I see that the subset issue is solved!
So now, I just need to update the metadata.pb with
subsets: "kana-extended" right?

@simoncozens
Copy link
Collaborator Author

Yes please!

@emmamarichal
Copy link
Collaborator

Status:

When I added the subset 'kana-extended', it broke the dev-server. Garret fixed that, and re-pushed the subset update.
Currently, the metadata.pb shows well subsets: "kana-extended" and the subset is in the CSS:

/* kana-extended */
@font-face {
  font-family: 'Noto Serif Hentaigana';
  font-style: normal;
  font-weight: 400;
  src: url(https://fonts-dev.sandbox.google.com/l/font?kit=uk-OEHi3o6EruUbj3pGaDj3siVARn-kqgu1eOHk7wYK23O0hzowGm6QyfE06aDix6dU&skey=a3caba7afda0bcbb&v=dev) format('woff2');
  unicode-range: U+3099-309C, U+1B100-1B122;
}

However, I still see that in the dev-server:

Screenshot 2024-08-07 at 15 28 52

@simoncozens Do you know if we need language option like languages: "ain_Kana" # Ainu, to make it works?

cc @garretrieger @nathan-williams

@simoncozens
Copy link
Collaborator Author

We probably need a language option, but more to the point we also need some Hentaigana sample text. I'll work on some.

However, I am not seeing the subset correctly in dev; if I enter Hentaigana in the type tester, I get tofu: (This is with U+1B01B)

Screenshot 2024-08-08 at 09 25 44

@simoncozens
Copy link
Collaborator Author

Sample text PR: #8013.

The kana extended subset definition looks correct. Eng may need to repush. @garretrieger @nathan-williams

@chrissimpkins
Copy link
Collaborator

We included this in the to_sandbox list and will check subsetting again following the sandbox push.

@emmamarichal
Copy link
Collaborator

Works in Sandbox! I add it to the to_production list.
Screenshot 2024-09-12 at 14 10 48

@simoncozens
Copy link
Collaborator Author

No longer working in sandbox?!

Screenshot 2024-10-18 at 16 06 19

@vv-monsalve vv-monsalve added the -- Needs Eng team opinion API related stuff only eng team can answer label Nov 8, 2024
@vv-monsalve
Copy link
Collaborator

Hi @garretrieger, @nathan-williams

The target script is not shown consistently in the Sandbox server.

  • It displays it ok in the font preview.
Screenshot 2024-11-08 at 15 13 28
  • But then when entering to the font's specimen page, it only shows Latin.
Screenshot 2024-11-08 at 15 14 12

We consider all the necessary pieces to have been fulfilled. Could you please assist us in understanding the situation with it? Is there anything else needed from our side for the font to show up correctly in the UI?

  • Subset: subsets: "kana-extended"
  • Script primary_script: "Hira"
  • And the sample for the language was included in #8013

@vv-monsalve vv-monsalve added the -- Bad rendering Hinting issue mostly, or inconsistencies among servers label Nov 15, 2024
@emmamarichal
Copy link
Collaborator

@nyshadhr9, if you have time to take a look at this :)
This font is blocked for a moment, and we don't know what is the blocker

@emmamarichal emmamarichal removed the -- Bad rendering Hinting issue mostly, or inconsistencies among servers label Dec 11, 2024
@chrissimpkins
Copy link
Collaborator

What is the status here?

@emmamarichal
Copy link
Collaborator

Status:

We now have tofu everywhere (dev-sandbox + sandbox) cc @rsheeter

Screenshot 2025-01-14 at 15 52 29 Screenshot 2025-01-14 at 15 52 41

@emmamarichal
Copy link
Collaborator

Update: this PR should solve it!
#8909 thanks @simoncozens!

@simoncozens
Copy link
Collaborator Author

@rsheeter This does point to some weirdness in the API, where if a font has both primary_language and sample_text, the primary language field is winning. I would have expected the sample_text field, which is specific to the font, to be displayed.

@simoncozens
Copy link
Collaborator Author

This is now behaving nicely in dev, can go to sandbox please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Eng team opinion API related stuff only eng team can answer I New Font II CJK Chinese, Japanese, Korean scripts
Projects
Status: In Sandbox
Development

Successfully merging this pull request may close these issues.

4 participants