Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample text for Hentaigana #8013

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add sample text for Hentaigana #8013

merged 1 commit into from
Aug 16, 2024

Conversation

simoncozens
Copy link
Collaborator

No description provided.

@simoncozens simoncozens added I Lang languages and sample texts I Metadata/OFL labels Aug 10, 2024
Copy link

FontBakery report

fontbakery version: 0.12.9

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoSerifHentaigana[wght].ttf
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]

  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]

All other checks

[15] NotoSerifHentaigana[wght].ttf
🔥 FAIL Combined length of family and style must not exceed 32 characters.
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight ExtraLight' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 268 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight ExtraLight' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 268 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Light' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 269 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Light' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 269 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Regular' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 270 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Regular' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 270 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Medium' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 271 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Medium' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 271 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 272 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 272 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Bold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 273 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Bold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 273 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight ExtraBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 274 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight ExtraBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 274 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Black' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 275 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif Hentaigana ExtraLight Black' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 275 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • ⚠️ WARN

    Name ID 6 'NotoSerifHentaigana-ExtraLight' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 559 among a set of 6 math glyphs.
    The following math glyphs have a different width, though:

Width = 310: minus

[code: width-outliers]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
  • ⚠️ WARN

    No dotted circle glyph present


    [code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: į̆ į̇ į̈ į̊ į̋ į̒ į̦̀ į̦́ į̦̂ į̦̃ į̦̄ į̦̆ į̦̇ į̦̈ į̦̊ į̦̋ į̦̌ į̦̒ į̧̀ į̧́

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Bafut (Latn, 158,146 speakers), Kom (Latn, 360,685 speakers), Fur (Latn, 1,230,163 speakers), Nateni (Latn, 100,000 speakers), Nzakara (Latn, 50,000 speakers), Dan (Latn, 1,099,244 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ebira (Latn, 2,200,000 speakers), Dii (Latn, 71,000 speakers), Basaa (Latn, 332,940 speakers), Zapotec (Latn, 490,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Mango (Latn, 77,000 speakers), Ma’di (Latn, 584,000 speakers), Vute (Latn, 21,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lugbara (Latn, 2,200,000 speakers), Aghem (Latn, 38,843 speakers), South Central Banda (Latn, 244,000 speakers), Avokaya (Latn, 100,000 speakers), Gulay (Latn, 250,478 speakers), Mundani (Latn, 34,000 speakers), Igbo (Latn, 27,823,640 speakers), Cicipu (Latn, 44,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ejagham (Latn, 120,000 speakers), Navajo (Latn, 166,319 speakers), Yala (Latn, 200,000 speakers), Ekpeye (Latn, 226,000 speakers), Mfumte (Latn, 79,000 speakers), Makaa (Latn, 221,000 speakers), Sar (Latn, 500,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers).

[code: soft-dotted]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, tifinagh, coptic
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: malayalam, tai-le, syriac, old-permic, tifinagh, canadian-aboriginal, math, coptic
  • U+030A COMBINING RING ABOVE: try adding syriac 262 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: kana-extended, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Does the font contain less than 150 CJK characters?
  • ⚠️ WARN

    There are only 2 CJK glyphs when there needs to be at least 150 in order to support the smallest CJK writing system, Kana.
    The following CJK glyphs were found:
    ['uni3099', 'uni309A']
    Please check that these glyphs have the correct unicodes.


    [code: cjk-not-enough-glyphs]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO Font follows the family naming recommendations?
  • ℹ️ INFO

    Font does not follow some family naming recommendations:

Field Value Recommendation
Family Name Noto Serif Hentaigana ExtraLight exceeds max length (31)
[code: bad-entries]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/notoserifhentaigana


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notoserifhentaigana/NotoSerifHentaigana[wght].ttf
Dehinted Size 443.9kb
Hinted Size 444.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 7 46 9 189 0
0% 0% 0% 3% 18% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

The sample text included in the metadata looks unintelligible is not possible to review here. I'll merge this here and inspect it on dev server.

@vv-monsalve vv-monsalve merged commit 794d811 into main Aug 16, 2024
7 checks passed
@vv-monsalve vv-monsalve deleted the hentaigana-sample branch August 16, 2024 04:32
@vv-monsalve vv-monsalve removed the I Lang languages and sample texts label Aug 16, 2024
@m4rc1e
Copy link
Collaborator

m4rc1e commented Oct 18, 2024

I don't think this has made it to the dev server since the sample text is latin.

Screenshot 2024-10-18 at 15 50 17

@garretrieger @simoncozens

@emmamarichal
Copy link
Collaborator

Ah? I saw it working in sandbox: #7327 (comment)

@vv-monsalve
Copy link
Collaborator

This PR can be tracked by #7327. I'm removing this one from the Traffic jam board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants