Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prove we don't match fontmake for Glyphs italic and fix it #1158

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Prove we don't match fontmake for Glyphs italic and fix it #1158

merged 1 commit into from
Dec 3, 2024

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Dec 2, 2024 

# main
$ python resources/scripts/ttx_diff.py 'https://github.com/Omnibus-Type/Faustina#sources/Faustina-Italic.glyphs' | grep DIFF
  DIFF 'OS_2', build/default/fontmake.OS_2.ttx (98.1%)
  DIFF 'STAT', build/default/fontmake.STAT.ttx (93.8%)
  DIFF 'fvar', build/default/fontmake.fvar.ttx (97.7%)
  DIFF 'glyf', build/default/fontmake.glyf.ttx (100.0%)
  DIFF 'head', build/default/fontmake.head.ttx (95.5%)
  DIFF 'hmtx', build/default/fontmake.hmtx.ttx (99.9%)
  DIFF 'name', build/default/fontmake.name.ttx (96.4%)

# this branch
$ python resources/scripts/ttx_diff.py 'https://github.com/Omnibus-Type/Faustina#sources/Faustina-Italic.glyphs' | grep DIFF
  DIFF 'glyf', build/default/fontmake.glyf.ttx (100.0%)
  DIFF 'hmtx', build/default/fontmake.hmtx.ttx (99.9%)

JMM if happy

@rsheeter rsheeter force-pushed the gname branch 2 times, most recently from 6a892d4 to 4b9cae5 Compare December 2, 2024 22:30
@rsheeter rsheeter added this to the fontc 1.0 milestone Dec 2, 2024
@rsheeter rsheeter added this pull request to the merge queue Dec 2, 2024
@rsheeter rsheeter removed this pull request from the merge queue due to a manual request Dec 2, 2024
cmyr
cmyr approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmyr cmyr added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit a9e919c Dec 3, 2024
10 checks passed
@cmyr cmyr deleted the gname branch December 3, 2024 00:13
@rsheeter rsheeter mentioned this pull request Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
fontc 1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rsheeter @cmyr