feat(helm): add option to use deployment type instead of daemonset in canary #17364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenbachir
changed the title
abenbachir
force-pushed
the
abderb/canary
branch
from
50681a6 to
6a90f82
Compare
github-actions
bot
added
the
type/docs
abenbachir
force-pushed
the
abderb/canary
branch
from
6a90f82 to
02cfc6a
Compare
Signed-off-by: Abderrahmane Benbachir <abderb@dropbox.com>
abenbachir
force-pushed
the
abderb/canary
branch
from
02cfc6a to
220fa95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently lokiCananry uses the DaemonSet that end up creating 7000 pods in our cluster, since there is no possible way to limit number of containers deployed with Daemonset, I added an optional config to be able to switch to Deployment type
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR