Skip to content

feat(helm): add option to use deployment type instead of daemonset in canary #17364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(helm): add option to use deployment type instead of daemonset in canary #17364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6681,6 +6681,15 @@ null
<td><pre lang="json">
null
</pre>
</td>
</tr>
<tr>
<td>lokiCanary.kind</td>
<td>string</td>
<td>The type of the loki canary k8s rollout. This can be a DaemonSet or Deployment.</td>
<td><pre lang="json">
"DaemonSet"
</pre>
</td>
</tr>
<tr>
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Helm chart for Grafana Loki and Grafana Enterprise Logs supporting monolithic, s
|------------|------|---------|
| https://charts.min.io/ | minio(minio) | 5.4.0 |
| https://grafana.github.io/helm-charts | grafana-agent-operator(grafana-agent-operator) | 0.5.1 |
| https://grafana.github.io/helm-charts | rollout_operator(rollout-operator) | 0.24.0 |
| https://grafana.github.io/helm-charts | rollout_operator(rollout-operator) | 0.27.1 |

Find more information in the Loki Helm Chart [documentation](https://grafana.com/docs/loki/next/installation/helm).

Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/templates/loki-canary/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{- if .enabled -}}
---
apiVersion: apps/v1
kind: DaemonSet
kind: {{ .kind }}
metadata:
name: {{ include "loki-canary.fullname" $ }}
namespace: {{ $.Release.Namespace }}
Expand Down
2 changes: 2 additions & 0 deletions production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,8 @@ test:
# that it's working correctly
lokiCanary:
enabled: true
# -- The type of the loki canary k8s rollout. This can be a DaemonSet or Deployment.
kind: DaemonSet
# -- If true, the canary will send directly to Loki via the address configured for verification --
# -- If false, it will write to stdout and an Agent will be needed to scrape and send the logs --
push: true
Expand Down
Loading