Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does this Do
This attempts to address Issue-191. That issue describes a problem where
homepage
props are dropped from Manifests in a Collection if the manifest was created via themake_ manifest()
helper. Oddly, the issue doesn't exist if manifests are created and added to the Collection in other ways.The issue appears to be that the helper uses the
Manifest
class rather thanManifestRef
. If we switch the classes, things seem to work as expected.Todo: what if items prop exists in incoming kwargs?
Any potential regressions
I don't think so. I've added ManifestRef to the AutoIdConfig helper incase someone was using
make_manifest()
without adding anid
property since that worked on Manifest but not ManifestRef. I've also had to addManifestRef
to the AutoLang helper. For some reason, this doesn't work onManifestRef
even thoughReference
is listed.