Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 0.97] bump multus-dynamic-networks v0.3.6 #1983

Open
wants to merge 1 commit into
base: release-0.97
Choose a base branch
from

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Jan 15, 2025

What this PR does / why we need it:
This PR is a manual bump of multus-dynamic-networks to v0.3.6

Special notes for your reviewer:

Release note:

NONE

Signed-off-by: Ram Lavi <ralavi@redhat.com>
@RamLavi RamLavi requested a review from oshoval January 15, 2025 08:35
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 15, 2025
@kubevirt-bot kubevirt-bot requested a review from qinqon January 15, 2025 08:35
@RamLavi RamLavi changed the title [Release 0.97] bump multus syn 0.3.6 [Release 0.97] bump multus-dynamic-networks v0.3.6 Jan 15, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 15, 2025

/retest

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

@ashokpariya0
Copy link
Contributor

@ashokpariya0
Copy link
Contributor

Hi @ashokpariya0 can be related to multi arch ? https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1983/pull-cluster-network-addons-operator-unit-test-release-0.97/1879450504979812352#1:build-log.txt%3A5461 exec container process /bin/sh: Exec format error

let me check.

The command CNAO_VERSION=99.0.0 ./hack/components/bump-linux-bridge.sh is failing during the creation of the multi-architecture image.

The issue is unclear, especially since all previous PRs worked fine after the multi-architecture change for the linux-bridge, and even the last PR passed the unit tests successfully. so not sure why it started failing now, It seems the problem might be related to the node where the build is occurring. Specifically, the node could be running an older version of Podman, which may not support multi-architecture builds, causing the failure ???

may be to unblock we remove platform=all for linux-bridge, we already have multi-arch image so should be okay??

@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

lets first indeed unblock please, we don't need multi arch on release 0.97
can you do it please?

maybe it was forked before all the changes were merged ?
next we can debug it on main, if it happens

Thanks

@ashokpariya0
Copy link
Contributor

Kindly rebase the PR.

@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

/retest

prow auto rebase
thanks

@oshoval
Copy link
Collaborator

oshoval commented Jan 15, 2025

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@kubevirt-bot
Copy link
Collaborator

@RamLavi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cnao-lifecycle-k8s-release-0.97 0182acd link unknown /test pull-e2e-cnao-lifecycle-k8s-release-0.97
pull-e2e-cnao-workflow-k8s-release-0.97 0182acd link unknown /test pull-e2e-cnao-workflow-k8s-release-0.97

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@oshoval
Copy link
Collaborator

oshoval commented Jan 16, 2025

i wonder if this was just one timer flake or repeats
#1983 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants