-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support connector hints #117
Conversation
re |
Name for the Source/Sink/Connector deployers doesn't include the partial view information:
yields {{name}} == "kafka-database-existing-topic-2" If you have many partial views on the same topic, it won't be unique. Imagine the case of setting a specific consumer group for each source, it would need to be unique to this pipeline |
It should yield |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think partialViewName
is a bit leaky, since the planner doesn't otherwise know about partial views. Could we get away with pipelineName
here?
For the intended use-cases (e.g. consumer groups, client IDs, etc), can they just use the full pipeline name, e.g. kafka-database-existingtopic1-foo
?
hoptimator-jdbc/src/main/java/com/linkedin/hoptimator/jdbc/HoptimatorDdlExecutor.java
Outdated
Show resolved
Hide resolved
hoptimator-k8s/src/main/java/com/linkedin/hoptimator/k8s/K8sJobDeployer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for sending you around in circles. Make sense, thanks.
Two changes: