Hattrick support request
It would be a huge help for Foxtrick team if some things were implemented on the HT side.
Admittedly, this is a rather large list that need not be done at once or even fully completed to be useful.
The items are sorted roughly in the order of decreasing importance.
Thank you for your time and consideration. Every little bit helps.
- NEW!!!
- CHPP API enhancements
- Changes that would be useful to reduce complexity/instability
- Useful feature requests
- Other remarks
- DONE \o/
These are new ideas/difficulties that came up since the list was first created.
Tactic rating is currently only specified in match event texts. However, this was historically an unavailable/hidden/unknown feature, meaning that not all languages use the available tactic rating.
It would be nice to list the tactical rating somewhere separately in the UI. This is especially true for the old HT-Live since it is still available as an option via HT settings.
ht.playerManager.players array in Match Order interface has a lot of useful data we can use:
However, one distinct information is curiously missing: mother club bonus. Would it be possible to add it?
Transfer compare helpfully lists the criteria used to develop the player list:
We have an idea to list the attributes of the original player (i. e. the one that is being compared to) in a table alongside these criteria. However these are done using plain text nodes and are L10N-dependent.
First option would be creating this feature on the HT side. Barring that, it would be nice to wrap age and skill names in spans with distinct class names. E.g.:
<span class="pm">Playmaking</span> = <a href="/Help/Rules/AppDenominations.aspx?lt=skill&ll=10#skill" class="skill">outstanding</a>We need MOAR data 😃
-
youthtraining: get current training and the one that was active during last match or by
matchIDeven -
avatars: avatars for NT
teamIDs are unavailable (throw errors); ability to get avatar byplayerID -
playerdetails: new field:
matchesCurrentTeam -
players:
TransferDetails,GoalsCurrentTeamandArrivalDatefrom playerdetails;OwnerNotesis curiously missing for Seniors; new field:matchesCurrentTeam. -
nationalplayers is too bare, needs more fields from players, esp.
Specialty; avatar info as well perhaps? - search: no youth support, esp. youth leagues
These changes would make more features possible/bug-free or allow us to implement them without CHPP access.
- There are no avatars for NT teams in avatars.xml (ticket id #34855).
- Similarly, it is not possible to get NT player specialties unless fetching them one by one for each player.
- Generally speaking, match data from
#matchdata [id$="lblPlayerData"]is very useful on the match report page. It would be nice to have specialty/avatar information here as well.
Leaving matchID blank for the old match lineup page would redirect to the last played match. Trying the same with the new match page leads to an error Expected=matchID.
It would be nice to have this functionality for the new match lineup page as well.
When you go to a HTH tab (e. g. Latest matches) for a tournament match the tab link uses tournament teamIDs, e. g. HomeTeamID=7504003 (my teamID is actually 672194).
We'd like to use real HomeTeamID and AwayTeamID values on HTH. My testing indicates the actual teamID values are not really needed (can be 0) for HT to show the correct match list. Other tabs break though.
Alternatively, HT team IDs could be added somewhere else in HTML, of course.
A lot of trouble comes from the fact that same things are done differently all over Hattrick.
For example, we have quite a popular feature that turns main site menu into a drop down menu:
It learns and fills up on the fly by traversing the DOM. However it requires quite a lot of hacks since the menu is different all over the place on each page. E.g. some links in #sidebar (right menu) are often wrapped in paragraphs or spans; useless <br> or other styling elements are used. You could make use of some consistent util functions for some things ;)
Anyway, the actual small problem that leads to another set of hacks is this:
Why would you guys use a different structure for the same purpose? Would it be possible to make Manager network identical to mail: replace the (1) link with a span and remove the Network span?
These requests are needed for extremely frequent user feature requests that would require a lot of CHPP access
Supported teams page includes links to next and previous match for each team. However, additional information about the matches (match type icon, most importantly) would be invaluable to enable filtering & sorting.
We've been asked numerous times to include player salary and character on transfer search result page. Using CHPP for each player in this case is extremely inefficient.
People also want to see secondary team info on forum messages
Some things proposed to us are better handled by HTs. Other things are just friendly reminders directly from Foxtrick team;)
There are multiple warnings on stage in the form:
Mixed Content: The page at 'https://stage.hattrick.org/Club/' was loaded over HTTPS, but requested an insecure image 'http://res.hattrick.org/kits/13/129/1281/1280529/matchKitLarge.png'. This content should also be served over HTTPS.
Team player list and match report are the worst.
These requests have been fulfilled already and are here for archive purposes only. We are dully grateful for your cooperation.
There is a common theme with a lot of the problems: textNodes. They tend to over-complicate things for us. E. g. see this match:
Proposal:
<h1 class="hasByline">
<span class="teamName">Footballeurs de rue</span>
<span id="matchResult">0 - 8</span>
<a href="/Club/?TeamID=1757282" title="Yaute FC" class="teamName">Yaute FC</a>
</h1>As visible in the image below, when a match is collapsed in HT-Live both team names are joined in a textNode.
[collapsed state]
[expanded state, i. e. .rtsSelected]
There are a few problems with this. Firstly, some team names include ' - ' in them (no kidding) making team name detection buggy in collapsed state. Secondly, only short names are used (in expanded case as well) making own team detection problematic and the title attribute useless. Thirdly, street teams are just the worst!
Proposal to wrap team names in collapsed state and use full team names for the title attribute:
<!-- collapsed state -->
<span class="teamName" title="FC Evaldas">Evaldas</span>
-
<span class="teamName" title="Kavalieriai">Kavalieriai</span>
<!-- expanded state -->
<a href="/Club/?TeamID=273107&BrowseIds=273107,671242" title="FC Evaldas">Evaldas</a>
-
<a href="/Club/?TeamID=671242&BrowseIds=671242,273107" title="Kavalieriai">Kavalieriai</a>
<!-- P.S. street teams should use span.teamName here as well -->
Fan club name may include numbers and that (along with uncertainty from L10N) makes fan club size detection buggy. Proposal:
<p>Sirgalių klube Stormers F.C yra <span id="fanClubSize">127</span> nariai</p>
Once HTO filter was introduced on the match page people on stage complained that Match archive still displays HTO matches by default. Similar checkbox was promised there but was not delivered.
There is actually a filter there but the default view is All that includes HTO. Personally I don't find much sense in displaying HTO matches in archive at all (they are soon deleted). As a compromise there perhaps should be another category (All -HTO) that is displayed by default.