Skip to content
This repository was archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1876751 - Remove redundant preferences from SettingsFragment #5320

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

t-p-white
Copy link
Contributor

@t-p-white t-p-white commented Jan 26, 2024

ℹ️ See BZ for full details.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1876751

@sarah541 sarah541 added approved PR that has been approved and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Jan 26, 2024
@t-p-white t-p-white added the 🛬 needs landing PRs that are ready to land label Jan 29, 2024
@mergify mergify bot merged commit 2c2244a into mozilla-mobile:main Jan 29, 2024
23 checks passed
@t-p-white t-p-white deleted the 1876751 branch January 31, 2024 10:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved PR that has been approved 🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants