refactor(common): Switch TypeScript module to node16
#14976
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Borewit
force-pushed
the
enable-ts-dynamic-import
branch
3 times, most recently
from
1a88ce2 to
7eed6f0
Compare
|
|
Borewit
force-pushed
the
enable-ts-dynamic-import
branch
6 times, most recently
from
83b01ee to
8f1537b
Compare
Borewit
force-pushed
the
enable-ts-dynamic-import
branch
5 times, most recently
from
b429908 to
a8ca949
Compare
fix(deps): update dependency fastify to v5.3.1
Borewit
force-pushed
the
enable-ts-dynamic-import
branch
from
a8ca949 to
159dfa5
Compare
|
@kamilmysliwiec you mind have look at remaining failing unit tests? The FileTypeValidator does not seem to recognize any file running in CircleCI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Node.js compiler option
modulefromcommonjstonode16, to preserve dynamic import. Withcommonjsthese are converted torequire. This allows to deprecate theload-esmdependency, introduced in 1e43fcb.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Uses
load-esmto be able to load ESM module file-type.Improvement of #14974.
What is the new behavior?
Switches to a more modern version of CommonJS in the TypeScript compiler, which allow dynamic import, which no longer requires load-esm.
Does this PR introduce a breaking change?
Other information