Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Slack notifications #78

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fixes Slack notifications #78

merged 2 commits into from
Sep 23, 2024

Conversation

merschformann
Copy link
Member

Description

Fixed internal Slack notifications.

Changes

  • Removed unnecessary quotes around the Slack URL in the release workflow.
  • Updated the condition to check for Slack URL presence more effectively in the release script.

@merschformann merschformann marked this pull request as draft September 23, 2024 21:35
auto-merge was automatically disabled September 23, 2024 21:35

Pull request was converted to draft

@merschformann merschformann marked this pull request as ready for review September 23, 2024 21:35
@merschformann merschformann merged commit 6898488 into develop Sep 23, 2024
37 checks passed
@merschformann merschformann deleted the merschformann/fix-notify branch September 23, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-quintero sebastian-quintero sebastian-quintero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merschformann @sebastian-quintero