Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Slack notifications #78

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fixes Slack notifications #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7a140
Fixing slack notification
merschformann Sep 23, 2024
d3ec432
Updating manifest after each released app, not failing fast in releas…
merschformann Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
runs-on: ubuntu-latest
needs: determine_environments
strategy:
fail-fast: false
matrix:
environment: ${{fromJson(needs.determine_environments.outputs.environments)}}
environment: ${{ matrix.environment }}
Expand Down Expand Up @@ -227,7 +228,7 @@ jobs:
export PATH=$PATH:~/.nextmv # Make CLI available in non-interactive shell
export SLACK_NOTIFY_PARAM="" # Only notify slack for prod releases
if [ ${{ matrix.environment }} == "prod" ]; then
export SLACK_NOTIFY_PARAM="--slack-url \"${{ secrets.SLACK_URL_MISSION_CONTROL }}\""
export SLACK_NOTIFY_PARAM="--slack-url ${{ secrets.SLACK_URL_MISSION_CONTROL }}"
fi
python main.py \
--apps "${{ env.APPS }}" \
Expand Down
16 changes: 8 additions & 8 deletions .nextmv/release/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,21 +86,21 @@ def main():
workflow_app=workflow_app,
)

if options.slack_url is not None:
manifest.upload(
client=client,
bucket=options.bucket,
folder=options.folder,
manifest_file=options.manifest,
)

if options.slack_url:
notify_slack(
url=options.slack_url,
app=name,
version=new_app_version,
marketplace_version=new_marketplace_version,
)

manifest.upload(
client=client,
bucket=options.bucket,
folder=options.folder,
manifest_file=options.manifest,
)


def push_app(name: str, version: str, workflow_app: WorkflowApp):
"""
Expand Down
Loading